Review main Merged

54059[TASK] Use Response objects directly in Install Tool actions

Benni Mack CR +2 V +2 Hard +283 −104 updated 09/10/17, 16:07

Commit message

The patch introduces three shorthand Response classes for output:
HtmlResponse, JsonResponse and RedirectResponse which are used
throughout all the actions inside the Install Tool.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Markus Hölzle +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Markus Hölzle +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1117

  1. Benni Mack uploaded patch set 1 09/09/17, 11:48

  2. TYPO3com voted on patch set 1 V -1 09/09/17, 12:35 Completed build in 47m 01s on Sat, 9 Sep, 02:35 PM Test Summary: 58152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14653

  3. TYPO3com commented on patch set 1 09/09/17, 13:52 Completed build in 2h 50m 33s on Sat, 9 Sep, 03:52 PM Test Summary: 58152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14653

  4. Benni Mack uploaded patch set 2 09/09/17, 15:59

  5. TYPO3com voted on patch set 2 V -1 09/09/17, 16:21 Completed build in 21m 22s on Sat, 9 Sep, 06:21 PM Test Summary: 2 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14693

  6. Benni Mack uploaded patch set 3 09/09/17, 18:54

  7. TYPO3com voted on patch set 3 V -1 09/09/17, 19:13 Completed build in 19m 30s on Sat, 9 Sep, 09:13 PM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14726

  8. Markus Hölzle voted on patch set 3 CR +1 09/09/17, 20:24

  9. Benni Mack uploaded patch set 4 09/09/17, 21:33

  10. TYPO3com voted on patch set 4 V -1 09/09/17, 21:33 Completed build in 10s on Sat, 9 Sep, 11:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14752

  11. Benni Mack uploaded patch set 5 09/09/17, 23:05

  12. TYPO3com voted on patch set 5 V +1 09/09/17, 23:21 Completed build in 15m 53s on Sun, 10 Sep, 01:21 AM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14761

  13. Christian Kuhn voted on patch set 5 CR +1 V +1 09/10/17, 13:57

  14. Stefan Neufeind voted on patch set 5 CR +1 09/10/17, 14:07

  15. Markus Hölzle voted on patch set 5 CR +1 V +1 09/10/17, 16:04

  16. Benni Mack voted on patch set 5 CR +2 V +2 09/10/17, 16:07

  17. Gerrit merged patch set 5 09/10/17, 16:07