54059[TASK] Use Response objects directly in Install Tool actions
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
- Markus Hölzle +1
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Markus Hölzle +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/core/Classes/Http/HtmlResponse.phpnew+46 −0
- typo3/sysext/core/Classes/Http/JsonResponse.phpnew+113 −0
- typo3/sysext/core/Classes/Http/RedirectResponse.phpnew+48 −0
- typo3/sysext/install/Classes/Controller/Action/Ajax/AbstractAjaxAction.php+8 −3
- typo3/sysext/install/Classes/Controller/Action/AbstractAction.php+8 −3
- typo3/sysext/install/Classes/Controller/Action/ActionInterface.php+4 −2
- typo3/sysext/install/Classes/Controller/AbstractController.php+14 −50
- typo3/sysext/install/Classes/Controller/AjaxController.php+16 −20
- typo3/sysext/install/Classes/Controller/StepController.php+21 −21
- typo3/sysext/install/Classes/Controller/ToolController.php+2 −2
- typo3/sysext/install/Classes/Http/RecoveryRequestHandler.php+2 −2
- typo3/sysext/install/Classes/Http/RequestHandler.php+1 −1
Review log 1117
-
Benni Mack uploaded patch set 1 09/09/17, 11:48
-
TYPO3com voted on patch set 1 V -1 09/09/17, 12:35 Completed build in 47m 01s on Sat, 9 Sep, 02:35 PM Test Summary: 58152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14653
-
TYPO3com commented on patch set 1 09/09/17, 13:52 Completed build in 2h 50m 33s on Sat, 9 Sep, 03:52 PM Test Summary: 58152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14653
-
Benni Mack uploaded patch set 2 09/09/17, 15:59
-
TYPO3com voted on patch set 2 V -1 09/09/17, 16:21 Completed build in 21m 22s on Sat, 9 Sep, 06:21 PM Test Summary: 2 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14693
-
Benni Mack uploaded patch set 3 09/09/17, 18:54
-
TYPO3com voted on patch set 3 V -1 09/09/17, 19:13 Completed build in 19m 30s on Sat, 9 Sep, 09:13 PM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14726
-
Markus Hölzle voted on patch set 3 CR +1 09/09/17, 20:24
-
Benni Mack uploaded patch set 4 09/09/17, 21:33
-
TYPO3com voted on patch set 4 V -1 09/09/17, 21:33 Completed build in 10s on Sat, 9 Sep, 11:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14752
-
Benni Mack uploaded patch set 5 09/09/17, 23:05
-
TYPO3com voted on patch set 5 V +1 09/09/17, 23:21 Completed build in 15m 53s on Sun, 10 Sep, 01:21 AM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14761
-
Christian Kuhn voted on patch set 5 CR +1 V +1 09/10/17, 13:57
-
Stefan Neufeind voted on patch set 5 CR +1 09/10/17, 14:07
-
Markus Hölzle voted on patch set 5 CR +1 V +1 09/10/17, 16:04
-
Benni Mack voted on patch set 5 CR +2 V +2 09/10/17, 16:07
-
Gerrit merged patch set 5 09/10/17, 16:07