Review main Merged Breaking

54068[!!!][TASK] Remove CMS base ViewHelper classes

Claus Due CR +2 V +2 Expert +179 −995 updated 12/12/17, 08:36

Commit message

This patch sacrifices two features:

* Having $this->controllerContext on ViewHelpers
* Support for render method arguments

And by doing so, allows the removal of every CMS
base ViewHelper class and several overrides they
implement. The base classes are still available as
class aliases to limit the breaking change to the two
features mentioned above.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 31

Show 11 more files

Review log 2940

Show 815 earlier messages
  1. Claus Due uploaded patch set 1 09/09/17, 15:13

  2. TYPO3com voted on patch set 1 V -1 09/09/17, 15:13 Completed build in 09s on Sat, 9 Sep, 05:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14687

  3. Stefan Neufeind commented on patch set 1 CR -1 09/09/17, 16:49

    will take care of the build-failure
  4. Stefan Neufeind commented on patch set 2 09/09/17, 16:49

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V -1 09/09/17, 17:06 Completed build in 16m 37s on Sat, 9 Sep, 07:06 PM Test Summary: 8 of 58413 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14700

  6. TYPO3com commented on patch set 2 09/09/17, 17:10 Completed build in 37m 35s on Sat, 9 Sep, 07:10 PM Test Summary: 8 of 58413 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14700

  7. Andreas Kienast commented on patch set 2 CR -1 V -1 09/09/17, 17:13

    "Sacrificing features" patch is heavily breaking. Please mark that patch as breaking and add a ReST file. BTW, the acceptance test failures are "real" failures, so there must be something wrong.
  8. Claus Due uploaded patch set 3 09/10/17, 20:06

  9. TYPO3com voted on patch set 3 V -1 09/10/17, 20:06 Completed build in 08s on Sun, 10 Sep, 10:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14848

  10. Claus Due uploaded patch set 4 09/10/17, 20:22

  11. TYPO3com voted on patch set 4 V -1 09/10/17, 20:22 Completed build in 06s on Sun, 10 Sep, 10:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14849

  12. Claus Due uploaded patch set 5 09/10/17, 20:24

  13. TYPO3com voted on patch set 5 V -1 09/10/17, 20:40 Completed build in 15m 29s on Sun, 10 Sep, 10:40 PM Test Summary: 8 of 58413 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14850

  14. Claus Due uploaded patch set 6 09/10/17, 20:40

  15. TYPO3com voted on patch set 6 V -1 09/10/17, 20:57 Completed build in 16m 31s on Sun, 10 Sep, 10:57 PM Test Summary: 1 of 58413 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14851

  1. Tymoteusz Motylewski commented on patch set 6 CR -1 09/11/17, 07:21

    Nice change! If it;s breaking, please add an rst and [!!!] in the commit message.
  2. Benni Mack commented on patch set 6 11/24/17, 21:17

    Claus, care to update the patch, so we can continue with that one for 9.0 (breaking etc)
  3. Claus Due commented on patch set 6 11/26/17, 17:33

    @Benni I can take care of the rebase, RST etc. but I may need a hand in fixing the functional tests.
  4. Claus Due uploaded patch set 7 11/30/17, 20:23

  5. Claus Due uploaded patch set 8 11/30/17, 20:24

  6. Claus Due uploaded patch set 9 11/30/17, 20:28

  7. Benni Mack voted on patch set 9 CR +1 11/30/17, 20:31

  8. TYPO3com voted on patch set 7 V -1 11/30/17, 20:34 Completed build in 10m 51s on Thu, 30 Nov, 09:34 PM Test Summary: 14 of 57359 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17134

  9. TYPO3com voted on patch set 8 V -1 11/30/17, 20:37 Completed build in 12m 41s on Thu, 30 Nov, 09:37 PM Test Summary: 14 of 57359 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17135

  10. TYPO3com voted on patch set 9 V +1 11/30/17, 20:38 Completed build in 10m 01s on Thu, 30 Nov, 09:38 PM Test Summary: 56986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17136

  11. Claus Due commented on patch set 9 11/30/17, 20:39

    Should be all ready to go!
  12. Wouter Wolters voted on patch set 9 CR +1 11/30/17, 20:41

  13. Benni Mack commented on patch set 9 11/30/17, 21:02

    LegacyClassesForIde.php:106

    argument definition class alias is missing here...
  14. Benni Mack commented on patch set 9 V +1 11/30/17, 21:04

    composer dump-autoload helped ;)
  15. Claus Due commented on patch set 9 11/30/17, 21:04

    That's actually intentional, though it wouldn't hurt to add it. There were as far as I could tell zero use cases that target the CMS ArgumentDefinition and it's not exactly an API class.
  16. Claus Due commented on patch set 9 11/30/17, 21:05

    Oh right it was added... but they're not completely compatible. The sixth constructor argument will be completely ignored.
  17. Georg Ringer commented on patch set 9 12/05/17, 14:09

    Breaking-82414-RemoveCMSBaseViewHelperClasses.rst:40

    missing is the chapter "migration" which should: - link to an example how a VH looks like without render method - which classes must be used instead of the removed ones

    Breaking-82414-RemoveCMSBaseViewHelperClasses.rst:42

    that is acutally wrong, nothing is scanned
  18. Benni Mack commented on patch set 10 12/05/17, 15:34

    Published edit on patch set 9.
  19. Benni Mack voted on patch set 10 CR +1 V +1 12/05/17, 15:34

  20. TYPO3com voted on patch set 10 V +1 12/05/17, 15:45 Completed build in 10m 34s on Tue, 5 Dec, 04:45 PM Test Summary: 57015 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17208

  21. Wouter Wolters voted on patch set 10 CR +1 12/05/17, 18:46

  22. Georg Ringer voted on patch set 10 CR +2 V +2 12/05/17, 19:36

  23. Gerrit merged patch set 10 12/05/17, 19:36

  24. Frans Saris commented on patch set 11 12/12/17, 08:33

    post -1

    MediaViewHelper.php:164

    This breaks as it doesn't trigger the inject methods on `ImageService`
  25. Frans Saris commented on patch set 11 12/12/17, 08:36