Review main Merged

54072[TASK] Add descriptions to dropdowns in Install Tool - All Configuration

Benni Mack CR +2 V +2 Normal +81 −32 updated 09/09/17, 17:47

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Joerg Kummer +1
  • Verified V +2
    • Christian Kuhn +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 812

  1. Benni Mack uploaded patch set 1 09/09/17, 16:55

  2. TYPO3com voted on patch set 1 V -1 09/09/17, 17:12 Completed build in 16m 24s on Sat, 9 Sep, 07:12 PM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14701

  3. Christian Kuhn commented on patch set 1 CR +1 V +1 09/09/17, 17:12

    :)

    DefaultConfigurationDescription.yaml:100

    note: this option is unused in core.
  4. TYPO3com commented on patch set 1 09/09/17, 17:21 Completed build in 42m 11s on Sat, 9 Sep, 07:21 PM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14701

  5. TYPO3com voted on patch set 1 V +1 09/09/17, 17:24 Completed build in 1h 11m 09s on Sat, 9 Sep, 07:24 PM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14701

  6. Wouter Wolters commented on patch set 1 09/09/17, 17:25

    SubSection.html:53

    use a space here instead of tab
  7. Christian Kuhn commented on patch set 2 09/09/17, 17:27

    Published edit on patch set 1.
  8. Christian Kuhn commented on patch set 2 CR +1 V +1 09/09/17, 17:28

    SubSection.html:53 Reply

    Done
  9. Joerg Kummer voted on patch set 2 CR +1 V +1 09/09/17, 17:34

  10. TYPO3com voted on patch set 2 V +1 09/09/17, 17:47 Completed build in 19m 26s on Sat, 9 Sep, 07:47 PM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14707

  11. Christian Kuhn voted on patch set 2 CR +2 V +2 09/09/17, 17:47

  12. Gerrit merged patch set 2 09/09/17, 17:47