Review main Merged Breaking

54086[!!!][TASK] Remove old typoscript constants editor defaults option

Markus Hölzle CR +2 V +2 Normal +39 −19 updated 09/10/17, 11:06

Commit message

Remove support for the special constant comment
`###MOD_TS:EDITABLE_CONSTANTS###`. This constant was used to show
all constants before this comment as default constants in constants
editor and is dropped as ancient and widely unknown and rarely used
feature.

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Hölzle +1
    • Joerg Kummer +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 911

  1. Markus Hölzle uploaded patch set 1 09/09/17, 21:04

  2. TYPO3com voted on patch set 1 V +1 09/09/17, 21:23 Completed build in 18m 31s on Sat, 9 Sep, 11:23 PM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14745

  3. Joerg Kummer commented on patch set 1 09/10/17, 08:24

    Breaking-82425-RemoveOldTyposcriptConstantsEditorOptionMOD_TSEDITABLE_CONSTANTS.rst

    Question: shouldn't this doc being declared for master instead of 8.7 and moved from Documentation/Changelog/8.7 to Documentation/Changelog/master?
  4. Benni Mack uploaded patch set 2 09/10/17, 08:51

  5. Benni Mack voted on patch set 2 CR +1 V +1 09/10/17, 08:52

  6. Joerg Kummer voted on patch set 2 CR +1 V +1 09/10/17, 08:54

  7. Christian Kuhn voted on patch set 2 CR +1 09/10/17, 09:00

  8. TYPO3com voted on patch set 2 V +1 09/10/17, 09:20 Completed build in 28m 45s on Sun, 10 Sep, 11:20 AM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14784

  9. Markus Hölzle voted on patch set 2 CR +1 09/10/17, 09:22

  10. Benni Mack voted on patch set 2 CR +2 V +2 09/10/17, 11:06

  11. Gerrit merged patch set 2 09/10/17, 11:06