Review main Merged

54099[TASK] Add main admin to system maintainers during first install

Simon Praetorius CR +2 V +2 Easy +6 −3 updated 10/06/17, 09:25

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Sommer +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Sommer +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1826

Show 1 earlier messages
  1. Simon Praetorius uploaded patch set 1 09/10/17, 11:43

  1. Benni Mack voted on patch set 1 CR +1 09/10/17, 11:46

  2. TYPO3com voted on patch set 1 V -1 09/10/17, 11:59 Completed build in 15m 21s on Sun, 10 Sep, 01:59 PM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14817

  3. TYPO3com commented on patch set 1 09/10/17, 12:22 Completed build in 54m 11s on Sun, 10 Sep, 02:22 PM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14817

  4. TYPO3com commented on patch set 1 09/10/17, 12:23 Completed build in 1h 34m 00s on Sun, 10 Sep, 02:23 PM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14817

  5. Benni Mack commented on patch set 1 09/10/17, 14:55

    strange, we did not touch this area (it's step 3) during this change...
  6. Markus Hölzle voted on patch set 1 CR +1 09/10/17, 16:21

  7. Joerg Kummer commented on patch set 1 CR +1 V +1 09/10/17, 17:32

    Tested
  8. Sascha Rademacher voted on patch set 1 CR +1 V +1 09/18/17, 08:54

  9. TYPO3com commented on patch set 1 09/18/17, 09:04 Completed build in 22h 54m 15s on Mon, 18 Sep, 11:04 AM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14817

  10. TYPO3com commented on patch set 1 09/18/17, 09:44 Completed build in 20h 54m 29s on Mon, 18 Sep, 11:44 AM Test Summary: 1 of 58503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14817

  11. Jörg Bösche voted on patch set 1 CR +1 V +1 09/20/17, 06:35

  12. Jörg Bösche voted on patch set 1 CR 0 V 0 09/20/17, 06:35

  13. Susi Moog commented on patch set 1 CR -1 09/20/17, 10:46

    FYI: You can see the details of the postgres fail here: https://bamboo.typo3.com/artifact/CORE-GTC/ACINSTPGPHP7071/build-14817/Test-Report/typo3temp/var/tests/AcceptanceReportsInstallPgsql/record_59bf95520e19f_InstallWithPgsqlCest__Install_typo3_on_pg_sql/index.html (and in general Bamboo saves the artifacts of the test runs) --> lastInsertId() is not working on postgres in this case, which was added in this patch set, so bamboo is correct in voting negative.
  14. Andreas Kienast commented on patch set 1 09/20/17, 11:27

    Maybe we need this change in first: https://review.typo3.org/#/c/51819/
  15. Benni Mack uploaded patch set 2 10/02/17, 23:38

  16. Benni Mack voted on patch set 2 CR +1 10/02/17, 23:38

  17. TYPO3com voted on patch set 2 V -1 10/02/17, 23:52 Completed build in 14m 21s on Tue, 3 Oct, 01:52 AM Test Summary: 1 of 57123 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15292

  18. Christian Kuhn rebased onto patch set 3 10/06/17, 08:23

  19. TYPO3com voted on patch set 3 V -1 10/06/17, 08:33 Completed build in 09m 24s on Fri, 6 Oct, 10:33 AM Test Summary: 1 of 56939 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15407

  20. Christian Kuhn uploaded patch set 4 10/06/17, 09:13

  21. TYPO3com voted on patch set 4 V +1 10/06/17, 09:23 Completed build in 09m 39s on Fri, 6 Oct, 11:23 AM Test Summary: 56580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15408

  22. Markus Sommer commented on patch set 4 CR +1 V +1 10/06/17, 09:24

    Work great :)
  23. Christian Kuhn voted on patch set 4 CR +2 V +2 10/06/17, 09:25

  24. Gerrit merged patch set 4 10/06/17, 09:25