Review main Merged

54111[BUGFIX] Install tool: Use standalone application in backend context

Christian Kuhn CR +2 V +2 Normal +64 −40 updated 09/11/17, 16:44

Commit message

With recent routing changes the install tool "backend context" has
been switched to a "normal" backend module loaded directly from
within the backend application. The standalone is an own application
with its own bootstrap.
This leads to various issues in the install tool since the backend
and standalone requests lead to different bootstrap states, for
instance TCA is initialized in BE context, but isn't in standalone.
Within backend, this won't change until the backend application can
bootstrap to different states depending on a controller.
To solve install tool related issues for now, the BackendModuleController
of the install tool called from within backend now starts a casual
install tool session and marks this session as "initiated from a
valid system maintainer". It then redirects to the standalone
application which omits login and enable install tool file check if
the session is marked as backend user session.

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 710

  1. Christian Kuhn uploaded patch set 1 09/11/17, 10:19

  2. TYPO3com voted on patch set 1 V -1 09/11/17, 10:20 Completed build in 09s on Mon, 11 Sep, 12:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14857

  3. Christian Kuhn uploaded patch set 2 09/11/17, 10:21

  4. Christian Kuhn uploaded patch set 3 09/11/17, 10:22

  5. TYPO3com voted on patch set 2 V +1 09/11/17, 10:37 Completed build in 15m 57s on Mon, 11 Sep, 12:37 PM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14858

  6. TYPO3com voted on patch set 3 V +1 09/11/17, 10:40 Completed build in 18m 09s on Mon, 11 Sep, 12:40 PM Test Summary: 58140 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14859

  7. Anja Leichsenring voted on patch set 3 CR +1 V +1 09/11/17, 11:16

  8. Benni Mack commented on patch set 3 09/11/17, 16:25

    BackendModuleController.php:93

    could you please use getAbsoluteWebPath() - so we're safe when we introduce speaking URLs for BE.
  9. Benni Mack voted on patch set 3 CR +2 V +2 09/11/17, 16:44

  10. Gerrit merged patch set 3 09/11/17, 16:44