Review main Merged

54117[TASK] Remove system environment check for Soap

Claus Due CR +2 V +2 Easy +0 −3 updated 09/14/17, 08:45

Commit message

TYPO3 no longer requires the Soap extension and
should not check for it in system environment checks.

This patch removes the check.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Stephan Großberndt +1
    • Wouter Wolters +1
    • Alexander Schnitzler +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1013

  1. Claus Due uploaded patch set 1 09/11/17, 14:26

  2. Mathias Brodala commented on patch set 1 CR -1 09/11/17, 14:41

    If you are 100% sure about this, you also need to remove this from composer.json and INSTALL.md
  3. TYPO3com voted on patch set 1 V +1 09/11/17, 14:42 Completed build in 15m 39s on Mon, 11 Sep, 04:42 PM Test Summary: 58146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14872

  4. Claus Due uploaded patch set 2 09/11/17, 15:06

  5. Stephan Großberndt voted on patch set 2 CR +1 09/11/17, 15:25

  6. TYPO3com voted on patch set 2 V -1 09/11/17, 15:25 Completed build in 18m 28s on Mon, 11 Sep, 05:25 PM Test Summary: 1 of 58509 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14877

  7. TYPO3com voted on patch set 2 V +1 09/11/17, 15:27 Completed build in 39m 04s on Mon, 11 Sep, 05:27 PM Test Summary: 58146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14877

  8. Georg Ringer voted on patch set 2 CR +1 V +1 09/11/17, 17:04

  9. Wouter Wolters voted on patch set 2 CR +1 09/11/17, 18:55

  10. Alexander Schnitzler voted on patch set 2 CR +1 V +1 09/14/17, 08:04

  11. Christian Kuhn voted on patch set 2 CR +2 V +2 09/14/17, 08:44

  12. Gerrit merged patch set 2 09/14/17, 08:44

  13. Christian Kuhn commented on patch set 3 09/14/17, 08:45

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 0e43839c3eb669c655a6fa8c23104210ba7c1709