54119[TASK] Improve TranslateViewHelper compiling
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Schreiber +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1927
Show 2 earlier messages
-
TYPO3com voted on patch set 1 V -1 09/11/17, 15:16 Completed build in 12m 33s on Mon, 11 Sep, 05:16 PM Test Summary: 6 of 58268 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14876
-
TYPO3com voted on patch set 2 V +1 09/11/17, 15:29 Completed build in 16m 02s on Mon, 11 Sep, 05:29 PM Test Summary: 58146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14878
-
Georg Ringer commented on patch set 2 09/11/17, 17:03
something for 8.7 as well? -
Andreas Kienast commented on patch set 2 09/12/17, 05:43
Sorry, but I'm fully against backporting further Fluid patches into 8.7 -
Reiner Teubner uploaded patch set 3 02/06/18, 13:54
-
TYPO3com voted on patch set 3 V -1 02/06/18, 13:54 Completed build in 10s on Tue, 6 Feb, 02:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19015
-
Reiner Teubner uploaded patch set 4 02/06/18, 13:56
-
Claus Due commented on patch set 4 02/06/18, 13:58
Reiner, any particular reason why you seem to have hijacked this patch to add additional arguments (= new FEATURE) to this non-breaking, non-API-modifying TASK? -
Claus Due commented on patch set 4 02/06/18, 13:59
Ah, nevermind, looks like that patch set was indeed a mistake. -
TYPO3com voted on patch set 4 V -1 02/06/18, 14:01 Completed build in 05m 28s on Tue, 6 Feb, 03:01 PM Test Summary: 71 of 30595 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19016
-
Reiner Teubner commented on patch set 4 02/06/18, 14:14
What? hijacked?? :( The only reason I touched this patch is to solve the merge conflict and keep the patch alive. But looks like i make a mistake. I hope you can forgive me. -
Claus Due commented on patch set 4 02/06/18, 14:19
No problem Reiner, I just saw the first patch that added new arguments and thought that was a bit of an odd thing to do. I see in the meantime those arguments are there in the master branch so it was a simple rebase thing ;) -
Claus Due rebased onto patch set 5 03/01/18, 21:41
-
Claus Due uploaded patch set 6 03/01/18, 21:49
-
TYPO3com voted on patch set 5 V -1 03/01/18, 21:53 Completed build in 11m 37s on Thu, 1 Mar, 10:53 PM Test Summary: 71 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20402
-
Claus Due uploaded patch set 7 03/01/18, 21:56
-
Claus Due uploaded patch set 8 03/01/18, 21:59
-
TYPO3com voted on patch set 6 V +1 03/01/18, 21:59 Completed build in 10m 26s on Thu, 1 Mar, 10:59 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20404
-
TYPO3com voted on patch set 7 V -1 03/01/18, 22:05 Completed build in 09m 22s on Thu, 1 Mar, 11:05 PM Test Summary: 2938 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20405
-
TYPO3com voted on patch set 8 V +1 03/01/18, 22:09 Completed build in 09m 46s on Thu, 1 Mar, 11:09 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20406
-
Mathias Schreiber voted on patch set 8 V +1 CR +1 03/01/18, 22:53
-
Christian Kuhn voted on patch set 8 V +2 CR +2 03/01/18, 22:54
-
Christian Kuhn merged patch set 9 03/01/18, 22:54
-
Mathias Brodala commented on patch set 9 03/02/18, 08:23
Please have a look at https://review.typo3.org/55983 for a small simplification. -
Susi Moog commented on patch set 9 09/18/18, 08:00
This patch introduced a regression: https://forge.typo3.org/issues/86292