Review TYPO3_8-7 Abandoned

54121[BUGFIX] Use TCA to get `type` field instead of hardcoded fieldname

Benni Mack CR 0 V 0 Easy +25 −9 updated 10/02/17, 08:43

Commit message

The `type` field is configured via TCA and that configuration must
be used instead of hardcoding the fieldname.

Also change arrangement of the DataProvider load order to load
InitializeProcessedTca directly after ReturnUrl. This avoids the
need of accessing $GLOBALS['TCA'].

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 24

  1. Benni Mack commented on patch set 1 09/11/17, 17:02

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 09/11/17, 17:19 Completed build in 16m 54s on Mon, 11 Sep, 07:19 PM Test Summary: 1 of 59144 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-907

  3. TYPO3com voted on patch set 1 V +1 09/12/17, 05:40 Completed build in 12h 55m 05s on Tue, 12 Sep, 07:40 AM Test Summary: 58780 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-907

  4. Benni Mack abandoned the change 10/02/17, 08:43

    Sascha, see mattes' comments on the patch for master, I'll abandon this backport for the time being.