Review main Merged

54124[BUGFIX] EXT:form - merge properties with configuration settings

Ralf Zimmermann CR +2 V +2 Normal +187 −2 updated 12/07/17, 13:15

Commit message

Merge the properties set through the formDefinition with the
predefined properties from the base configuration.
Add tests for property part of FormElementInterface implementation.

Review

  • Code review CR +2
    • Susi Moog +2
    • Stefan Neufeind +1
    • Daniel Gohlke +1
    • Carlos Meyer +1
  • Verified V +2
    • Susi Moog +2
    • Daniel Gohlke +1
    • Carlos Meyer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1720

  1. Ralf Zimmermann uploaded patch set 1 09/12/17, 09:58

  2. TYPO3com voted on patch set 1 V +1 09/12/17, 10:15 Completed build in 16m 12s on Tue, 12 Sep, 12:15 PM Test Summary: 58146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14898

  3. Daniel Gohlke voted on patch set 1 CR +1 11/10/17, 08:18

  4. Daniel Gohlke voted on patch set 1 V +1 11/10/17, 08:40

  5. Henning Liebe voted on patch set 1 CR +1 11/28/17, 08:25

  6. Mathias Brodala voted on patch set 1 CR +1 V +1 12/06/17, 19:40

  7. Susi Moog commented on patch set 1 12/06/17, 19:55

    AbstractFormElement.php:155

    this looks like a totally attractive function for a small unit test ;)
  8. Björn Jacob commented on patch set 1 CR -1 12/06/17, 20:24

    Rico is on it.
  9. Rico Schueppel uploaded patch set 2 12/07/17, 10:20

  10. Rico Schueppel commented on patch set 2 CR +1 12/07/17, 10:26

    add tests for property part of FormElementInterface implementation in AbstractFormElement and Section classes
  11. TYPO3com voted on patch set 2 V +1 12/07/17, 10:30 Completed build in 10m 14s on Thu, 7 Dec, 11:30 AM Test Summary: 57039 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17300

  12. Stefan Neufeind voted on patch set 2 CR +1 12/07/17, 10:39

  13. Daniel Gohlke uploaded patch set 3 12/07/17, 10:52

  14. Daniel Gohlke voted on patch set 3 CR +1 V +1 12/07/17, 10:58

  15. Carlos Meyer voted on patch set 3 CR +1 V +1 12/07/17, 10:58

  16. Stefan Neufeind voted on patch set 3 CR +1 12/07/17, 11:01

  17. TYPO3com voted on patch set 3 V +1 12/07/17, 11:02 Completed build in 10m 44s on Thu, 7 Dec, 12:02 PM Test Summary: 57039 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17304

  18. Susi Moog voted on patch set 3 CR +2 V +2 12/07/17, 13:14

  19. Gerrit merged patch set 3 12/07/17, 13:14

  20. Susi Moog commented on patch set 4 12/07/17, 13:15

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ac6ab84eff952544c294283924aff35bdc7cd58c