54124[BUGFIX] EXT:form - merge properties with configuration settings
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Stefan Neufeind +1
- Daniel Gohlke +1
- Carlos Meyer +1
-
Verified V +2
- Susi Moog +2
- Daniel Gohlke +1
- Carlos Meyer +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractFormElement.php1+6 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/Section.php+6 −1
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractFormElementTest.phpnew+88 −0
- typo3/sysext/form/Tests/Unit/Domain/FormElements/SectionTest.phpnew+87 −0
Review log 1720
-
Ralf Zimmermann uploaded patch set 1 09/12/17, 09:58
-
TYPO3com voted on patch set 1 V +1 09/12/17, 10:15 Completed build in 16m 12s on Tue, 12 Sep, 12:15 PM Test Summary: 58146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14898
-
Daniel Gohlke voted on patch set 1 CR +1 11/10/17, 08:18
-
Daniel Gohlke voted on patch set 1 V +1 11/10/17, 08:40
-
Henning Liebe voted on patch set 1 CR +1 11/28/17, 08:25
-
Mathias Brodala voted on patch set 1 CR +1 V +1 12/06/17, 19:40
-
Susi Moog commented on patch set 1 12/06/17, 19:55
-
Björn Jacob commented on patch set 1 CR -1 12/06/17, 20:24
Rico is on it. -
Rico Schueppel uploaded patch set 2 12/07/17, 10:20
-
Rico Schueppel commented on patch set 2 CR +1 12/07/17, 10:26
add tests for property part of FormElementInterface implementation in AbstractFormElement and Section classes -
TYPO3com voted on patch set 2 V +1 12/07/17, 10:30 Completed build in 10m 14s on Thu, 7 Dec, 11:30 AM Test Summary: 57039 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17300
-
Stefan Neufeind voted on patch set 2 CR +1 12/07/17, 10:39
-
Daniel Gohlke uploaded patch set 3 12/07/17, 10:52
-
Daniel Gohlke voted on patch set 3 CR +1 V +1 12/07/17, 10:58
-
Carlos Meyer voted on patch set 3 CR +1 V +1 12/07/17, 10:58
-
Stefan Neufeind voted on patch set 3 CR +1 12/07/17, 11:01
-
TYPO3com voted on patch set 3 V +1 12/07/17, 11:02 Completed build in 10m 44s on Thu, 7 Dec, 12:02 PM Test Summary: 57039 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17304
-
Susi Moog voted on patch set 3 CR +2 V +2 12/07/17, 13:14
-
Gerrit merged patch set 3 12/07/17, 13:14
-
Susi Moog commented on patch set 4 12/07/17, 13:15
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ac6ab84eff952544c294283924aff35bdc7cd58c
AbstractFormElement.php:155