54126[BUGFIX] EXT:form - show message if a form could not be saved
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Daniel Gohlke +1
- Björn Jacob +1
-
Verified V +2
- Susi Moog +2
- Daniel Gohlke +1
- Björn Jacob +1
- TYPO3com +1 CI
Issues 2
Files 17
- typo3/sysext/form/Classes/Controller/FormEditorController.php1+33 −4
- typo3/sysext/form/Classes/Controller/FormManagerController.php1+76 −19
- typo3/sysext/form/Classes/Mvc/Configuration/Exception/FileWriteException.phpnew+24 −0
- typo3/sysext/form/Classes/Mvc/Configuration/YamlSource.php1+26 −6
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+17 −2
- typo3/sysext/form/Configuration/Yaml/FormEditorSetup.yaml+2 −0
- typo3/sysext/form/Documentation/Config/configuration/Index.rst+2 −0
- typo3/sysext/form/Documentation/Config/proto/formElements/formElementTypes/Form/formEditor/saveErrorFlashMessageMessage.rstnew+29 −0
- typo3/sysext/form/Documentation/Config/proto/formElements/formElementTypes/Form/formEditor/saveErrorFlashMessageTitle.rstnew+29 −0
- typo3/sysext/form/Documentation/Config/proto/formElements/formElementTypes/Form/formEditor.rst+2 −0
- typo3/sysext/form/Documentation/Config/proto/formElements/formElementTypes/Form.rst+6 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf+7 −0
- typo3/sysext/form/Resources/Private/Language/locallang_formManager_javascript.xlf+13 −1
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/Core.js+6 −2
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/Mediator.js1+13 −0
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/ViewModel.js+18 −3
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormManager/ViewModel.js+31 −3
Review log 2027
Show 2 earlier messages
-
Ralf Zimmermann uploaded patch set 1 09/12/17, 12:52
-
Mathias Brodala commented on patch set 1 09/12/17, 13:03
Generally thanks a lot for tackling this. :-)FormEditorController.php:63This should be moved down right before the according action.FormManagerController.php:81Same here.YamlSource.php:133How about "success"?
-
TYPO3com voted on patch set 1 V -1 09/12/17, 13:07 Completed build in 15m 01s on Tue, 12 Sep, 03:07 PM Test Summary: 1 of 58509 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14906
-
Ralf Zimmermann uploaded patch set 2 09/13/17, 09:51
-
Ralf Zimmermann updated the commit message in patch set 3 09/13/17, 09:54
-
TYPO3com voted on patch set 2 V +1 09/13/17, 10:08 Completed build in 17m 01s on Wed, 13 Sep, 12:08 PM Test Summary: 58146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14911
-
TYPO3com voted on patch set 3 V -1 09/13/17, 10:10 Completed build in 16m 31s on Wed, 13 Sep, 12:10 PM Test Summary: 1 of 58509 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14912
-
Daniel Gohlke voted on patch set 3 CR +1 11/10/17, 07:12
-
Daniel Gohlke uploaded patch set 4 11/10/17, 07:52
-
Daniel Gohlke voted on patch set 4 CR +1 V +1 11/10/17, 07:54
-
TYPO3com voted on patch set 4 V +1 11/10/17, 08:02 Completed build in 09m 20s on Fri, 10 Nov, 09:02 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16227
-
Björn Jacob commented on patch set 5 11/12/17, 07:06
Published edit on patch set 4. -
Björn Jacob voted on patch set 5 CR +1 11/12/17, 07:07
-
TYPO3com voted on patch set 5 V -1 11/12/17, 07:15 Completed build in 09m 19s on Sun, 12 Nov, 08:15 AM Test Summary: 2 of 57121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16264
-
Björn Jacob updated the commit message in patch set 6 11/13/17, 06:00
-
TYPO3com voted on patch set 6 V +1 11/13/17, 06:09 Completed build in 08m 48s on Mon, 13 Nov, 07:09 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16272
-
Daniel Gohlke voted on patch set 6 CR +1 V +1 11/24/17, 08:54
-
Björn Jacob commented on patch set 6 V -1 12/06/17, 16:05
I do not get the correct flash message. I have removed the "is writable" flag of the storage. -
Mathias Brodala commented on patch set 6 V -1 12/06/17, 17:36
Same here with "chmod 000 fileadmin/form_definitions" -
Mathias Brodala commented on patch set 6 12/06/17, 17:38
Mediator.js:222Shouldn't we actually forward the message from the server here? -
Mathias Brodala commented on patch set 6 CR -1 12/06/17, 17:47
On it. -
Mathias Brodala uploaded patch set 7 12/06/17, 18:31
-
TYPO3com voted on patch set 7 V +1 12/06/17, 18:42 Completed build in 10m 11s on Wed, 6 Dec, 07:42 PM Test Summary: 56991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17259
-
Daniel Gohlke voted on patch set 7 CR +1 V +1 12/06/17, 18:58
-
Björn Jacob voted on patch set 7 CR +1 V +1 12/06/17, 19:03
-
Susi Moog voted on patch set 7 CR +2 V +2 12/07/17, 07:34
-
Gerrit merged patch set 7 12/07/17, 07:34