Review main Merged

54126[BUGFIX] EXT:form - show message if a form could not be saved

Ralf Zimmermann CR +2 V +2 Hard +334 −40 updated 12/07/17, 07:34

Commit message

Notify the user if the form could not be saved.

Also remove the timeout of the error messages to ensure editors
have enough time to read and understand the message.

Review

  • Code review CR +2
    • Susi Moog +2
    • Daniel Gohlke +1
    • Björn Jacob +1
  • Verified V +2
    • Susi Moog +2
    • Daniel Gohlke +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 2

Files 17

Review log 2027

Show 2 earlier messages
  1. Ralf Zimmermann uploaded patch set 1 09/12/17, 12:52

  2. Mathias Brodala commented on patch set 1 09/12/17, 13:03

    Generally thanks a lot for tackling this. :-)

    FormEditorController.php:63

    This should be moved down right before the according action.

    FormManagerController.php:81

    Same here.

    YamlSource.php:133

    How about "success"?
  1. TYPO3com voted on patch set 1 V -1 09/12/17, 13:07 Completed build in 15m 01s on Tue, 12 Sep, 03:07 PM Test Summary: 1 of 58509 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14906

  2. Ralf Zimmermann uploaded patch set 2 09/13/17, 09:51

  3. Ralf Zimmermann updated the commit message in patch set 3 09/13/17, 09:54

  4. TYPO3com voted on patch set 2 V +1 09/13/17, 10:08 Completed build in 17m 01s on Wed, 13 Sep, 12:08 PM Test Summary: 58146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14911

  5. TYPO3com voted on patch set 3 V -1 09/13/17, 10:10 Completed build in 16m 31s on Wed, 13 Sep, 12:10 PM Test Summary: 1 of 58509 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14912

  6. Daniel Gohlke voted on patch set 3 CR +1 11/10/17, 07:12

  7. Daniel Gohlke uploaded patch set 4 11/10/17, 07:52

  8. Daniel Gohlke voted on patch set 4 CR +1 V +1 11/10/17, 07:54

  9. TYPO3com voted on patch set 4 V +1 11/10/17, 08:02 Completed build in 09m 20s on Fri, 10 Nov, 09:02 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16227

  10. Björn Jacob commented on patch set 5 11/12/17, 07:06

    Published edit on patch set 4.
  11. Björn Jacob voted on patch set 5 CR +1 11/12/17, 07:07

  12. TYPO3com voted on patch set 5 V -1 11/12/17, 07:15 Completed build in 09m 19s on Sun, 12 Nov, 08:15 AM Test Summary: 2 of 57121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16264

  13. Björn Jacob updated the commit message in patch set 6 11/13/17, 06:00

  14. TYPO3com voted on patch set 6 V +1 11/13/17, 06:09 Completed build in 08m 48s on Mon, 13 Nov, 07:09 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16272

  15. Daniel Gohlke voted on patch set 6 CR +1 V +1 11/24/17, 08:54

  16. Björn Jacob commented on patch set 6 V -1 12/06/17, 16:05

    I do not get the correct flash message. I have removed the "is writable" flag of the storage.
  17. Mathias Brodala commented on patch set 6 V -1 12/06/17, 17:36

    Same here with "chmod 000 fileadmin/form_definitions"
  18. Mathias Brodala commented on patch set 6 12/06/17, 17:38

    Mediator.js:222

    Shouldn't we actually forward the message from the server here?
  19. Mathias Brodala commented on patch set 6 CR -1 12/06/17, 17:47

    On it.
  20. Mathias Brodala uploaded patch set 7 12/06/17, 18:31

  21. TYPO3com voted on patch set 7 V +1 12/06/17, 18:42 Completed build in 10m 11s on Wed, 6 Dec, 07:42 PM Test Summary: 56991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17259

  22. Daniel Gohlke voted on patch set 7 CR +1 V +1 12/06/17, 18:58

  23. Björn Jacob voted on patch set 7 CR +1 V +1 12/06/17, 19:03

  24. Susi Moog voted on patch set 7 CR +2 V +2 12/07/17, 07:34

  25. Gerrit merged patch set 7 12/07/17, 07:34