Review main Abandoned

54129[BUGFIX] Improve the check of endtime in BackendUtility::getRecordIconAltText

Georg Ringer CR 0 V 0 Easy +4 −2 updated 09/16/18, 22:15

Commit message

The check for the endtime should also check the ctrl column and compare
it to the current date - just like done with the starttime.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1115

  1. Georg Ringer uploaded patch set 1 09/13/17, 04:07

  2. TYPO3com voted on patch set 1 V -1 09/13/17, 04:22 Completed build in 14m 30s on Wed, 13 Sep, 06:22 AM Test Summary: 1 of 58509 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14909

  3. TYPO3com voted on patch set 1 V +1 09/13/17, 07:24 Completed build in 3h 31m 57s on Wed, 13 Sep, 09:24 AM Test Summary: 58146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14909

  4. Oliver Klee updated the commit message in patch set 2 09/13/17, 08:41

  5. TYPO3com voted on patch set 2 V -1 09/13/17, 08:57 Completed build in 15m 40s on Wed, 13 Sep, 10:57 AM Test Summary: 1 of 58509 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14910

  6. Sascha Rademacher commented on patch set 2 CR -1 09/25/17, 08:45

    BackendUtility.php:1582

    why not "if ($ctrl['endtime'] && $row[$ctrl['endtime']] < $GLOBALS['EXEC_TIME']) {" ?
  7. Wouter Wolters voted on patch set 2 CR +1 09/26/17, 18:14

  8. Wouter Wolters rebased onto patch set 3 09/26/17, 18:14

  9. Wouter Wolters voted on patch set 3 CR +1 09/26/17, 18:14

  10. TYPO3com voted on patch set 3 V +1 09/26/17, 18:29 Completed build in 14m 13s on Tue, 26 Sep, 08:29 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15159

  11. Christian Kuhn commented on patch set 3 10/06/17, 11:16

    add a unit test for this?
  12. Christian Kuhn voted on patch set 3 CR -1 10/06/17, 11:16

  13. Christian Kuhn commented on patch set 3 10/06/17, 11:39

    Actually, I don't think this is buggy: as soon as an entime is set, the toolipt shows "end: 2 days" or "end: -2 days". I think that is rather useful and should stay as is.
  14. Benni Mack commented on patch set 3 03/20/18, 05:43

    OK. so what to do here?
  15. Christian Kuhn abandoned the change 09/16/18, 22:15

    we do nothing: i'll take the freedom to abandon the patch and reject the issue.