Review main Merged

54135[FEATURE] EXT:form - add file size validator

Ralf Zimmermann CR +2 V +2 Hard +424 −28 updated 12/07/17, 19:34

Commit message

A new ExtbaseValidator called "FileSizeValidator" has been added which
is able to validate a file resource regarding its file size. The
validator is also available within the form editor.

Review

  • Code review CR +2
    • Susi Moog +2
    • Daniel Gohlke +1
    • Carlos Meyer +1
    • Björn Jacob +1
  • Verified V +2
    • Susi Moog +2
    • Daniel Gohlke +1
    • Carlos Meyer +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 3147

Show 1322 earlier messages
  1. Ralf Zimmermann uploaded patch set 1 09/13/17, 14:02

  2. TYPO3com voted on patch set 1 V +1 09/13/17, 14:18 Completed build in 16m 13s on Wed, 13 Sep, 04:18 PM Test Summary: 58182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14918

  3. Ralf Zimmermann uploaded patch set 2 09/13/17, 14:21

  4. TYPO3com voted on patch set 2 V +1 09/13/17, 14:36 Completed build in 14m 20s on Wed, 13 Sep, 04:36 PM Test Summary: 58182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14921

  5. Ralf Zimmermann uploaded patch set 3 09/14/17, 09:43

  6. TYPO3com voted on patch set 3 V +1 09/14/17, 10:00 Completed build in 16m 13s on Thu, 14 Sep, 12:00 PM Test Summary: 58182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14933

  7. Daniel Gohlke voted on patch set 3 CR +1 12/06/17, 09:22

  8. Daniel Gohlke uploaded patch set 4 12/06/17, 09:45

  9. TYPO3com voted on patch set 4 V -1 12/06/17, 09:45 Completed build in 07s on Wed, 6 Dec, 10:45 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17218

  10. Daniel Gohlke uploaded patch set 5 12/06/17, 09:51

  11. Daniel Gohlke uploaded patch set 6 12/06/17, 09:58

  12. TYPO3com voted on patch set 5 V +1 12/06/17, 09:59 Completed build in 08m 18s on Wed, 6 Dec, 10:59 AM Test Summary: 57051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17219

  13. Daniel Gohlke uploaded patch set 7 12/06/17, 10:03

  14. TYPO3com voted on patch set 6 V +1 12/06/17, 10:08 Completed build in 09m 59s on Wed, 6 Dec, 11:08 AM Test Summary: 57051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17220

  15. TYPO3com voted on patch set 7 V +1 12/06/17, 10:13 Completed build in 10m 10s on Wed, 6 Dec, 11:13 AM Test Summary: 57051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17221

  16. Daniel Gohlke commented on patch set 7 V -1 12/06/17, 11:19

    Error message in frontend should shows a user friendly error message if file size exceeds the upload_max_filesize. The detailed error should goes to the log.
  17. Carlos Meyer uploaded patch set 8 12/07/17, 09:06

  18. TYPO3com voted on patch set 8 V -1 12/07/17, 09:07 Completed build in 08s on Thu, 7 Dec, 10:07 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17292

  19. Carlos Meyer uploaded patch set 9 12/07/17, 09:13

  20. TYPO3com voted on patch set 9 V +1 12/07/17, 09:23 Completed build in 09m 26s on Thu, 7 Dec, 10:23 AM Test Summary: 57027 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17293

  21. Daniel Gohlke voted on patch set 9 CR +1 12/07/17, 12:35

  22. Daniel Gohlke uploaded patch set 10 12/07/17, 12:47

  1. Carlos Meyer voted on patch set 10 CR +1 V +1 12/07/17, 12:47

  2. Daniel Gohlke voted on patch set 10 CR +1 V +1 12/07/17, 12:47

  3. TYPO3com voted on patch set 10 V +1 12/07/17, 12:57 Completed build in 09m 45s on Thu, 7 Dec, 01:57 PM Test Summary: 57027 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17321

  4. Björn Jacob commented on patch set 11 12/07/17, 15:00

    Published edit on patch set 10.
  5. Björn Jacob commented on patch set 12 12/07/17, 15:03

    Published edit on patch set 11.
  6. TYPO3com voted on patch set 11 V +1 12/07/17, 15:11 Completed build in 10m 27s on Thu, 7 Dec, 04:11 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17338

  7. Björn Jacob updated the commit message in patch set 13 12/07/17, 15:11

  8. Björn Jacob voted on patch set 13 CR +1 V +1 12/07/17, 15:11

  9. TYPO3com voted on patch set 12 V +1 12/07/17, 15:13 Completed build in 09m 58s on Thu, 7 Dec, 04:13 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17339

  10. Björn Jacob commented on patch set 14 12/07/17, 15:26

    Published edit on patch set 13.
  11. TYPO3com voted on patch set 13 V +1 12/07/17, 15:27 Completed build in 15m 35s on Thu, 7 Dec, 04:27 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17341

  12. Björn Jacob voted on patch set 14 CR +1 V +1 12/07/17, 15:28

  13. Daniel Gohlke voted on patch set 14 CR +1 V +1 12/07/17, 15:34

  14. TYPO3com voted on patch set 14 V +1 12/07/17, 15:37 Completed build in 10m 37s on Thu, 7 Dec, 04:37 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17347

  15. Carlos Meyer voted on patch set 14 CR +1 V +1 12/07/17, 16:21

  16. Björn Jacob commented on patch set 15 12/07/17, 16:56

    Published edit on patch set 14.
  17. Björn Jacob commented on patch set 16 12/07/17, 16:58

    Published edit on patch set 15.
  18. Björn Jacob commented on patch set 16 CR +1 V +1 12/07/17, 17:01

  19. TYPO3com voted on patch set 15 V +1 12/07/17, 17:04 Completed build in 07m 58s on Thu, 7 Dec, 06:04 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17355

  20. TYPO3com voted on patch set 16 V +1 12/07/17, 17:11 Completed build in 12m 55s on Thu, 7 Dec, 06:11 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17356

  21. Carlos Meyer voted on patch set 16 CR +1 V +1 12/07/17, 17:59

  22. Daniel Gohlke voted on patch set 16 CR +1 V +1 12/07/17, 17:59

  23. Susi Moog voted on patch set 16 CR +1 12/07/17, 19:33

  24. Susi Moog voted on patch set 16 CR +2 V +2 12/07/17, 19:34

  25. Gerrit merged patch set 16 12/07/17, 19:34