54135[FEATURE] EXT:form - add file size validator
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Daniel Gohlke +1
- Carlos Meyer +1
- Björn Jacob +1
-
Verified V +2
- Susi Moog +2
- Daniel Gohlke +1
- Carlos Meyer +1
- Björn Jacob +1
- TYPO3com +1 CI
Issues 1
Files 11
- typo3/sysext/core/Documentation/Changelog/master/Feature-82177-ExtFormAddFileSizeValidator.rstnew+45 −0
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+19 −8
- typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php+12 −1
- typo3/sysext/form/Classes/Mvc/Validation/FileSizeValidator.phpnew+105 −0
- typo3/sysext/form/Classes/Mvc/ProcessingRule.php+12 −0
- typo3/sysext/form/Configuration/Yaml/BaseSetup.yaml+5 −0
- typo3/sysext/form/Configuration/Yaml/FormEditorSetup.yaml+38 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf+15 −0
- typo3/sysext/form/Resources/Private/Language/locallang.xlf+40 −19
- typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/ViewModel.js+6 −0
- typo3/sysext/form/Tests/Unit/Mvc/Validation/FileSizeValidatorTest.phpnew+127 −0
Review log 3147
Show 1322 earlier messages
-
Ralf Zimmermann uploaded patch set 1 09/13/17, 14:02
-
TYPO3com voted on patch set 1 V +1 09/13/17, 14:18 Completed build in 16m 13s on Wed, 13 Sep, 04:18 PM Test Summary: 58182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14918
-
Ralf Zimmermann uploaded patch set 2 09/13/17, 14:21
-
TYPO3com voted on patch set 2 V +1 09/13/17, 14:36 Completed build in 14m 20s on Wed, 13 Sep, 04:36 PM Test Summary: 58182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14921
-
Ralf Zimmermann uploaded patch set 3 09/14/17, 09:43
-
TYPO3com voted on patch set 3 V +1 09/14/17, 10:00 Completed build in 16m 13s on Thu, 14 Sep, 12:00 PM Test Summary: 58182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14933
-
Daniel Gohlke voted on patch set 3 CR +1 12/06/17, 09:22
-
Daniel Gohlke uploaded patch set 4 12/06/17, 09:45
-
TYPO3com voted on patch set 4 V -1 12/06/17, 09:45 Completed build in 07s on Wed, 6 Dec, 10:45 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17218
-
Daniel Gohlke uploaded patch set 5 12/06/17, 09:51
-
Daniel Gohlke uploaded patch set 6 12/06/17, 09:58
-
TYPO3com voted on patch set 5 V +1 12/06/17, 09:59 Completed build in 08m 18s on Wed, 6 Dec, 10:59 AM Test Summary: 57051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17219
-
Daniel Gohlke uploaded patch set 7 12/06/17, 10:03
-
TYPO3com voted on patch set 6 V +1 12/06/17, 10:08 Completed build in 09m 59s on Wed, 6 Dec, 11:08 AM Test Summary: 57051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17220
-
TYPO3com voted on patch set 7 V +1 12/06/17, 10:13 Completed build in 10m 10s on Wed, 6 Dec, 11:13 AM Test Summary: 57051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17221
-
Daniel Gohlke commented on patch set 7 V -1 12/06/17, 11:19
Error message in frontend should shows a user friendly error message if file size exceeds the upload_max_filesize. The detailed error should goes to the log. -
Carlos Meyer uploaded patch set 8 12/07/17, 09:06
-
TYPO3com voted on patch set 8 V -1 12/07/17, 09:07 Completed build in 08s on Thu, 7 Dec, 10:07 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17292
-
Carlos Meyer uploaded patch set 9 12/07/17, 09:13
-
TYPO3com voted on patch set 9 V +1 12/07/17, 09:23 Completed build in 09m 26s on Thu, 7 Dec, 10:23 AM Test Summary: 57027 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17293
-
Daniel Gohlke voted on patch set 9 CR +1 12/07/17, 12:35
-
Daniel Gohlke uploaded patch set 10 12/07/17, 12:47
-
Carlos Meyer voted on patch set 10 CR +1 V +1 12/07/17, 12:47
-
Daniel Gohlke voted on patch set 10 CR +1 V +1 12/07/17, 12:47
-
TYPO3com voted on patch set 10 V +1 12/07/17, 12:57 Completed build in 09m 45s on Thu, 7 Dec, 01:57 PM Test Summary: 57027 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17321
-
Björn Jacob commented on patch set 11 12/07/17, 15:00
Published edit on patch set 10. -
Björn Jacob commented on patch set 12 12/07/17, 15:03
Published edit on patch set 11. -
TYPO3com voted on patch set 11 V +1 12/07/17, 15:11 Completed build in 10m 27s on Thu, 7 Dec, 04:11 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17338
-
Björn Jacob updated the commit message in patch set 13 12/07/17, 15:11
-
Björn Jacob voted on patch set 13 CR +1 V +1 12/07/17, 15:11
-
TYPO3com voted on patch set 12 V +1 12/07/17, 15:13 Completed build in 09m 58s on Thu, 7 Dec, 04:13 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17339
-
Björn Jacob commented on patch set 14 12/07/17, 15:26
Published edit on patch set 13. -
TYPO3com voted on patch set 13 V +1 12/07/17, 15:27 Completed build in 15m 35s on Thu, 7 Dec, 04:27 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17341
-
Björn Jacob voted on patch set 14 CR +1 V +1 12/07/17, 15:28
-
Daniel Gohlke voted on patch set 14 CR +1 V +1 12/07/17, 15:34
-
TYPO3com voted on patch set 14 V +1 12/07/17, 15:37 Completed build in 10m 37s on Thu, 7 Dec, 04:37 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17347
-
Carlos Meyer voted on patch set 14 CR +1 V +1 12/07/17, 16:21
-
Björn Jacob commented on patch set 15 12/07/17, 16:56
Published edit on patch set 14. -
Björn Jacob commented on patch set 16 12/07/17, 16:58
Published edit on patch set 15. -
Björn Jacob commented on patch set 16 CR +1 V +1 12/07/17, 17:01
The documentation is handled separately: https://github.com/tritum/typo3-sysext-form-docs/commit/46b5cb60d0a10ca758b7dee090c7e6316129b5c9. -
TYPO3com voted on patch set 15 V +1 12/07/17, 17:04 Completed build in 07m 58s on Thu, 7 Dec, 06:04 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17355
-
TYPO3com voted on patch set 16 V +1 12/07/17, 17:11 Completed build in 12m 55s on Thu, 7 Dec, 06:11 PM Test Summary: 57075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17356
-
Carlos Meyer voted on patch set 16 CR +1 V +1 12/07/17, 17:59
-
Daniel Gohlke voted on patch set 16 CR +1 V +1 12/07/17, 17:59
-
Susi Moog voted on patch set 16 CR +1 12/07/17, 19:33
-
Susi Moog voted on patch set 16 CR +2 V +2 12/07/17, 19:34
-
Gerrit merged patch set 16 12/07/17, 19:34