54150[!!!][BUGFIX] Fix wrong error path of validation
Commit message
Review
-
Code review CR +2
- Benjamin Kott +2
- Mathias Schreiber +1
-
Verified V +2
- Benjamin Kott +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/8.7.x/Breaking-82093-ExtFormFieldPartialChanged.rstnew+57 −0
- typo3/sysext/core/Documentation/Changelog/master/Breaking-82093-ExtFormFieldPartialChanged.rst1new+57 −0
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+1 −1
- typo3/sysext/form/Resources/Private/Frontend/Partials/Field/Field.html+1 −1
Review log 2436
Show 611 earlier messages
-
TYPO3com uploaded patch set 1 09/15/17, 22:55
-
TYPO3com voted on patch set 1 V +1 09/15/17, 23:09 Completed build in 14m 13s on Sat, 16 Sep, 01:09 AM Test Summary: 58092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-14959
-
Susi Moog updated the commit message in patch set 2 09/20/17, 11:48
-
TYPO3com voted on patch set 2 V -1 09/20/17, 12:03 Completed build in 14m 42s on Wed, 20 Sep, 02:03 PM Test Summary: 1 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15066
-
TYPO3com voted on patch set 2 V +1 09/20/17, 12:06 Completed build in 32m 27s on Wed, 20 Sep, 02:06 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15066
-
Daniel Siepmann commented on patch set 2 CR +1 V +1 09/20/17, 13:11
What's necessary to "backport" this to TYPO3 CMS V8? -
Susi Moog updated the commit message in patch set 3 09/20/17, 13:12
-
TYPO3com voted on patch set 3 V +1 09/20/17, 13:27 Completed build in 14m 30s on Wed, 20 Sep, 03:27 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15072
-
Wouter Wolters voted on patch set 3 CR +1 10/18/17, 19:41
-
Johannes Hollmann commented on patch set 3 CR -1 V -1 10/23/17, 13:14
I have tested the fix. The property elementErrorClassAttribute works now correctly. But the fix brings another issue. Now the validationResults.errors and validationResults.flattenedErrors are not rendered in the fluid-templates -
Ralf Zimmermann voted on patch set 3 CR -1 12/06/17, 08:34
-
Patrick Biedert commented on patch set 3 V -1 CR -1 02/07/18, 16:10
I can confirm the issue that 'validationResults.errors' and 'validationResults.flattenedErrors' are empty in the templates after applying the patch -
Ralf Zimmermann uploaded patch set 4 02/22/18, 20:25
-
TYPO3com voted on patch set 4 V +1 02/22/18, 20:35 Completed build in 09m 32s on Thu, 22 Feb, 09:35 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20031
-
Tobi Kretschmann voted on patch set 4 CR +1 02/26/18, 09:06
-
Mathias Schreiber voted on patch set 4 CR +1 02/28/18, 16:04
-
Christian Kuhn commented on patch set 4 03/01/18, 17:25
Important-82093-ExtFormFieldPartialChanged.rst:4file should be in 8.7.x folder, not in 'master' if that patch is also back ported to v8, needs to be changed in both master and v8 backport, then.Important-82093-ExtFormFieldPartialChanged.rst:13'has been changed'Important-82093-ExtFormFieldPartialChanged.rst:19has been changed toImportant-82093-ExtFormFieldPartialChanged.rst:50'has changed to' -> 'change to' -
Ralf Zimmermann uploaded patch set 5 03/01/18, 17:40
-
Ralf Zimmermann commented on patch set 5 03/01/18, 17:42
Important-82093-ExtFormFieldPartialChanged.rst:4ReplyDoneImportant-82093-ExtFormFieldPartialChanged.rst:13ReplyDoneImportant-82093-ExtFormFieldPartialChanged.rst:19ReplyDoneImportant-82093-ExtFormFieldPartialChanged.rst:50ReplyDone -
TYPO3com voted on patch set 5 V -1 03/01/18, 17:50 Completed build in 09m 29s on Thu, 1 Mar, 06:50 PM Test Summary: 1 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20381
-
TYPO3com commented on patch set 5 03/06/18, 07:26 Completed build in 13h 54m 59s on Tue, 6 Mar, 08:26 AM Test Summary: 1 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20381
-
TYPO3com commented on patch set 5 03/06/18, 12:57 Completed build in 9h 11m 45s on Tue, 6 Mar, 01:57 PM Test Summary: 1 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20381
-
TYPO3com voted on patch set 5 V +1 03/06/18, 12:59 Completed build in 4h 30m 17s on Tue, 6 Mar, 01:59 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20381
-
Tobi Kretschmann voted on patch set 5 CR +1 03/06/18, 13:15
-
Benjamin Kott voted on patch set 5 V +1 CR +1 03/08/18, 08:45
-
Mathias Schreiber voted on patch set 5 V +1 CR +1 03/08/18, 08:58
-
Benjamin Kott updated the commit message in patch set 6 03/08/18, 09:22
-
Benjamin Kott uploaded patch set 7 03/08/18, 09:30
-
TYPO3com voted on patch set 6 V +1 03/08/18, 09:31 Completed build in 09m 10s on Thu, 8 Mar, 10:31 AM Test Summary: 30819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20672
-
Mathias Schreiber voted on patch set 7 V +1 CR +1 03/08/18, 09:31
-
Benjamin Kott voted on patch set 7 V +1 CR +1 03/08/18, 09:32
-
TYPO3com voted on patch set 7 V +1 03/08/18, 09:41 Completed build in 10m 32s on Thu, 8 Mar, 10:41 AM Test Summary: 30819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20673
-
Benjamin Kott voted on patch set 7 V +2 CR +2 03/08/18, 09:42
-
Benjamin Kott merged patch set 8 03/08/18, 09:42
-
Benjamin Kott commented on patch set 8 03/08/18, 09:42
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 9fe8fe139301eda74a6c9f9e685c60cd5a098e65 -
Christian Kuhn commented on patch set 8 03/08/18, 10:25
Breaking-82093-ExtFormFieldPartialChanged.rst:1this dupe should not have been added, the 8.7.x version is enough. see https://docs.typo3.org/typo3cms/extensions/core/latest/Changelog/Howto.html