Review main Merged

54166[TASK] Remove BackendUserRepository injection in NoteController

Georg Ringer CR +2 V +2 Normal +72 −16 updated 09/20/17, 10:14

Commit message

To improve the performance of sys_note rendering, the injection can
be skipped as the current user id can be used directly.

Review

  • Code review CR +2
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1317

  1. Georg Ringer uploaded patch set 1 09/19/17, 10:08

  2. TYPO3com voted on patch set 1 V -1 09/19/17, 10:08 Completed build in 09s on Tue, 19 Sep, 12:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15027

  3. Stefan Neufeind commented on patch set 1 09/19/17, 10:29

    Then the core still uses a deprecated function? Skipping the injection looks okay.
  4. Georg Ringer uploaded patch set 2 09/19/17, 11:57

  5. Georg Ringer commented on patch set 2 09/19/17, 11:57

    the core does not use the deprecated method but that allows it to be backported and no breaking change
  6. TYPO3com voted on patch set 2 V +1 09/19/17, 12:12 Completed build in 15m 30s on Tue, 19 Sep, 02:12 PM Test Summary: 58206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15029

  7. Georg Ringer uploaded patch set 3 09/19/17, 12:31

  8. Andreas Kienast commented on patch set 3 CR -1 09/19/17, 12:36

    Deprecations in 8.7?
  9. Georg Ringer commented on patch set 3 09/19/17, 12:43

    backport without the deprecation but with new method used
  10. TYPO3com voted on patch set 3 V +1 09/19/17, 12:47 Completed build in 16m 42s on Tue, 19 Sep, 02:47 PM Test Summary: 58206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15030

  11. Andreas Kienast voted on patch set 3 CR +1 09/19/17, 12:57

  12. Jörg Bösche voted on patch set 3 CR +1 09/20/17, 06:43

  13. Benni Mack updated the commit message in patch set 4 09/20/17, 08:34

  14. Benni Mack commented on patch set 4 CR +1 V +1 09/20/17, 08:34

    you deprecated sth - so this should go into master only (just updated the commit msg) Rest is fine
  15. TYPO3com voted on patch set 4 V +1 09/20/17, 10:11 Completed build in 1h 36m 59s on Wed, 20 Sep, 12:11 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15057

  16. Susi Moog voted on patch set 4 CR +2 V +2 09/20/17, 10:14

  17. Gerrit merged patch set 4 09/20/17, 10:14