54166[TASK] Remove BackendUserRepository injection in NoteController
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-82506-RemoveBackendUserRepositoryInjectionInNoteController.rstnew+32 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/sys_note/Classes/Controller/NoteController.php+1 −15
- typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php+32 −1
Review log 1317
-
Georg Ringer uploaded patch set 1 09/19/17, 10:08
-
TYPO3com voted on patch set 1 V -1 09/19/17, 10:08 Completed build in 09s on Tue, 19 Sep, 12:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15027
-
Stefan Neufeind commented on patch set 1 09/19/17, 10:29
Then the core still uses a deprecated function? Skipping the injection looks okay. -
Georg Ringer uploaded patch set 2 09/19/17, 11:57
-
Georg Ringer commented on patch set 2 09/19/17, 11:57
the core does not use the deprecated method but that allows it to be backported and no breaking change -
TYPO3com voted on patch set 2 V +1 09/19/17, 12:12 Completed build in 15m 30s on Tue, 19 Sep, 02:12 PM Test Summary: 58206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15029
-
Georg Ringer uploaded patch set 3 09/19/17, 12:31
-
Andreas Kienast commented on patch set 3 CR -1 09/19/17, 12:36
Deprecations in 8.7? -
Georg Ringer commented on patch set 3 09/19/17, 12:43
backport without the deprecation but with new method used -
TYPO3com voted on patch set 3 V +1 09/19/17, 12:47 Completed build in 16m 42s on Tue, 19 Sep, 02:47 PM Test Summary: 58206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15030
-
Andreas Kienast voted on patch set 3 CR +1 09/19/17, 12:57
-
Jörg Bösche voted on patch set 3 CR +1 09/20/17, 06:43
-
Benni Mack updated the commit message in patch set 4 09/20/17, 08:34
-
Benni Mack commented on patch set 4 CR +1 V +1 09/20/17, 08:34
you deprecated sth - so this should go into master only (just updated the commit msg) Rest is fine -
TYPO3com voted on patch set 4 V +1 09/20/17, 10:11 Completed build in 1h 36m 59s on Wed, 20 Sep, 12:11 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15057
-
Susi Moog voted on patch set 4 CR +2 V +2 09/20/17, 10:14
-
Gerrit merged patch set 4 09/20/17, 10:14