Review main Merged

54174[BUGFIX] Fix undefined variable to evaluate `fileFolder_recursions` correctly

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 09/22/17, 09:18

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Georg Ringer +1
  • Verified V +2
    • Frank Nägler +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Andreas Kienast uploaded patch set 1 09/19/17, 14:24

  2. Andreas Kienast updated the commit message in patch set 2 09/19/17, 14:25

  3. Christian Kuhn commented on patch set 2 09/19/17, 14:36

    -1 for 7.6 - this part was heavily rewritten in v8, i'll not take the risk to do that in v7
  4. Andreas Kienast commented on patch set 2 09/19/17, 14:43

    Ok, I just found that the variable is also undefined in 7.6
  5. Andreas Kienast updated the commit message in patch set 3 09/19/17, 14:43

  6. TYPO3com voted on patch set 1 V +1 09/19/17, 14:51 Completed build in 26m 26s on Tue, 19 Sep, 04:51 PM Test Summary: 58206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15041

  7. TYPO3com voted on patch set 2 V -1 09/19/17, 14:54 Completed build in 28m 57s on Tue, 19 Sep, 04:54 PM Test Summary: 1 of 58569 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15042

  8. TYPO3com voted on patch set 3 V +1 09/19/17, 15:04 Completed build in 20m 38s on Tue, 19 Sep, 05:04 PM Test Summary: 58206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15044

  9. Georg Ringer voted on patch set 3 CR +1 V +1 09/20/17, 19:30

  10. Frank Nägler voted on patch set 3 CR +2 V +2 09/22/17, 09:17

  11. Gerrit merged patch set 3 09/22/17, 09:17

  12. Frank Nägler commented on patch set 4 09/22/17, 09:18

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 71dc6b24dea87f9759d4b6b0252d74a427daa81c