54181[BUGFIX] Disable install tool access in switch user mode
Commit message
Review
-
Code review CR +2
- Morton Jonuschat +2
- Jan Stockfisch +1
- Sascha Rademacher +1
-
Verified V +2
- Morton Jonuschat +2
- Jan Stockfisch +1
- Sascha Rademacher +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1522
-
Mona Muzaffar uploaded patch set 1 09/20/17, 11:50
-
TYPO3com voted on patch set 1 V -1 09/20/17, 11:50 Completed build in 12s on Wed, 20 Sep, 01:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15067
-
Mona Muzaffar uploaded patch set 2 09/20/17, 11:55
-
TYPO3com voted on patch set 2 V -1 09/20/17, 12:10 Completed build in 15m 43s on Wed, 20 Sep, 02:10 PM Test Summary: 1 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15068
-
TYPO3com voted on patch set 2 V +1 09/20/17, 12:13 Completed build in 33m 53s on Wed, 20 Sep, 02:13 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15068
-
Andreas Kienast voted on patch set 2 CR +1 09/20/17, 13:32
-
Benni Mack commented on patch set 2 09/20/17, 14:43
-
Mona Muzaffar uploaded patch set 3 09/20/17, 15:56
-
Mona Muzaffar commented on patch set 2 09/20/17, 15:57
BackendUserAuthentication.php:464ReplyDone -
TYPO3com voted on patch set 3 V +1 09/20/17, 16:09 Completed build in 12m 56s on Wed, 20 Sep, 06:09 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15077
-
Wouter Wolters commented on patch set 4 09/20/17, 17:20
Published edit on patch set 3. -
Wouter Wolters commented on patch set 4 CR +1 09/20/17, 17:20
Made the comment gender neutral -
TYPO3com voted on patch set 4 V +1 09/20/17, 17:33 Completed build in 13m 44s on Wed, 20 Sep, 07:33 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15078
-
Christian Müllenhagen commented on patch set 4 CR -1 09/21/17, 12:43
BackendUserAuthentication.php:467Wouldn't it be more obvious to rename this variable to $systemMaintainers?BackendUserAuthentication.php:468Why don't you make this a bit more readable by extracting to a method that determines the real user id, like: { ... $userId = $this->getRealUserUid(); return in_array($userId, $allowedAdmins, true); } protected function getRealUserUid() { $switchModeUserUid = $GLOBALS['BE_USER']->user['ses_backuserid'] if ($switchModeUserUid) { return $switchModeUserUid; } return $this->user['uid']; } Then the code would be somehow self-explanatory and you could remove the superfluous comment. -
Benni Mack uploaded patch set 5 09/21/17, 18:44
-
TYPO3com voted on patch set 5 V -1 09/21/17, 18:59 Completed build in 14m 53s on Thu, 21 Sep, 08:59 PM Test Summary: 1 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15102
-
TYPO3com voted on patch set 5 V +1 09/23/17, 18:54 Completed build in 0h 24m 49s on Sat, 23 Sep, 08:54 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15102
-
Morton Jonuschat voted on patch set 5 CR +1 V +1 09/25/17, 00:13
-
Jan Stockfisch voted on patch set 5 CR +1 V +1 09/25/17, 08:01
-
Sascha Rademacher voted on patch set 5 CR +1 V +1 09/25/17, 10:31
-
Morton Jonuschat voted on patch set 5 CR +2 V +2 09/25/17, 13:28
-
Gerrit merged patch set 5 09/25/17, 13:28
BackendUserAuthentication.php:464