Review main Merged

54181[BUGFIX] Disable install tool access in switch user mode

Mona Muzaffar CR +2 V +2 Easy +12 −3 updated 09/25/17, 13:28

Commit message

During switch user mode the install tool modules are never visible.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Jan Stockfisch +1
    • Sascha Rademacher +1
  • Verified V +2
    • Morton Jonuschat +2
    • Jan Stockfisch +1
    • Sascha Rademacher +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1522

  1. Mona Muzaffar uploaded patch set 1 09/20/17, 11:50

  2. TYPO3com voted on patch set 1 V -1 09/20/17, 11:50 Completed build in 12s on Wed, 20 Sep, 01:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15067

  3. Mona Muzaffar uploaded patch set 2 09/20/17, 11:55

  4. TYPO3com voted on patch set 2 V -1 09/20/17, 12:10 Completed build in 15m 43s on Wed, 20 Sep, 02:10 PM Test Summary: 1 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15068

  5. TYPO3com voted on patch set 2 V +1 09/20/17, 12:13 Completed build in 33m 53s on Wed, 20 Sep, 02:13 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15068

  6. Andreas Kienast voted on patch set 2 CR +1 09/20/17, 13:32

  7. Benni Mack commented on patch set 2 09/20/17, 14:43

    BackendUserAuthentication.php:464

    this change basically means "If you're in SU mode, you are not system maintainer. If we change line 470 to sth like that: in_array((int)($GLOBALS['BE_USER']->user['ses_backuserid'] ?? $this->user['uid']), $allowedAdmins, true); that would be more flexible. A comment above the line would be nice too ;)
  8. Mona Muzaffar uploaded patch set 3 09/20/17, 15:56

  9. Mona Muzaffar commented on patch set 2 09/20/17, 15:57

    BackendUserAuthentication.php:464 Reply

    Done
  10. TYPO3com voted on patch set 3 V +1 09/20/17, 16:09 Completed build in 12m 56s on Wed, 20 Sep, 06:09 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15077

  11. Wouter Wolters commented on patch set 4 09/20/17, 17:20

    Published edit on patch set 3.
  12. Wouter Wolters commented on patch set 4 CR +1 09/20/17, 17:20

    Made the comment gender neutral
  13. TYPO3com voted on patch set 4 V +1 09/20/17, 17:33 Completed build in 13m 44s on Wed, 20 Sep, 07:33 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15078

  14. Christian Müllenhagen commented on patch set 4 CR -1 09/21/17, 12:43

    BackendUserAuthentication.php:467

    Wouldn't it be more obvious to rename this variable to $systemMaintainers?

    BackendUserAuthentication.php:468

    Why don't you make this a bit more readable by extracting to a method that determines the real user id, like: { ... $userId = $this->getRealUserUid(); return in_array($userId, $allowedAdmins, true); } protected function getRealUserUid() { $switchModeUserUid = $GLOBALS['BE_USER']->user['ses_backuserid'] if ($switchModeUserUid) { return $switchModeUserUid; } return $this->user['uid']; } Then the code would be somehow self-explanatory and you could remove the superfluous comment.
  15. Benni Mack uploaded patch set 5 09/21/17, 18:44

  16. TYPO3com voted on patch set 5 V -1 09/21/17, 18:59 Completed build in 14m 53s on Thu, 21 Sep, 08:59 PM Test Summary: 1 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15102

  17. TYPO3com voted on patch set 5 V +1 09/23/17, 18:54 Completed build in 0h 24m 49s on Sat, 23 Sep, 08:54 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15102

  18. Morton Jonuschat voted on patch set 5 CR +1 V +1 09/25/17, 00:13

  19. Jan Stockfisch voted on patch set 5 CR +1 V +1 09/25/17, 08:01

  20. Sascha Rademacher voted on patch set 5 CR +1 V +1 09/25/17, 10:31

  21. Morton Jonuschat voted on patch set 5 CR +2 V +2 09/25/17, 13:28

  22. Gerrit merged patch set 5 09/25/17, 13:28