Review main Merged

54183[BUGFIX] MenuProcessor: Allow sub keys of `addQueryString`

Andreas Kienast CR +2 V +2 Easy +1 −0 updated 09/22/17, 09:40

Commit message

THis patch allows sub keys of `addQueryString`, e.g. `exclude`.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Andreas Kienast uploaded patch set 1 09/20/17, 12:21

  2. TYPO3com voted on patch set 1 V -1 09/20/17, 12:34 Completed build in 13m 17s on Wed, 20 Sep, 02:34 PM Test Summary: 1 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15070

  3. TYPO3com voted on patch set 1 V +1 09/20/17, 12:38 Completed build in 30m 19s on Wed, 20 Sep, 02:38 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15070

  4. Susi Moog voted on patch set 1 CR +1 09/20/17, 12:55

  5. Susi Moog voted on patch set 1 V +1 09/20/17, 13:41

  6. Frank Nägler voted on patch set 1 CR +1 09/22/17, 09:27

  7. Frank Nägler voted on patch set 1 CR +2 V +2 09/22/17, 09:39

  8. Gerrit merged patch set 1 09/22/17, 09:40

  9. Frank Nägler commented on patch set 2 09/22/17, 09:40

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d1af7ba344b3782ed6db95287e7c2b34deade92f