Review TYPO3_7-6 Abandoned

54198[BUGFIX] Fix exception in FE when using predefined admPanel config

Markus Klein CR 0 V 0 Easy +1 −1 updated 10/23/17, 14:28

Commit message

Enforcing the admPanel for users via user TSconfig is working again
without crashing the FE.

We make sure that when the admPanel configuration is fetched, we
do not fall back to the toplevel value if the requested sub-value
does not exist.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 47

  1. Markus Klein commented on patch set 1 09/21/17, 12:10

    Cherry Picked from branch TYPO3_8-7.
  2. TYPO3com voted on patch set 1 V -1 09/21/17, 12:16 Completed build in 05m 10s on Thu, 21 Sep, 02:16 PM Test Summary: 6 of 39188 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1149

  3. TYPO3com commented on patch set 1 09/22/17, 09:42 Completed build in 21h 36m 45s on Fri, 22 Sep, 11:42 AM Test Summary: 6 of 39188 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1149

  4. Wouter Wolters rebased onto patch set 2 10/19/17, 19:45

  5. TYPO3com voted on patch set 2 V +1 10/19/17, 19:49 Completed build in 04m 28s on Thu, 19 Oct, 09:49 PM Test Summary: 39204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1174

  6. Christian Kuhn commented on patch set 2 10/20/17, 13:22

    i'm unable to reproduce the issue in v7 (but i was able to easily reproduce on master with reverting the code change).
  7. Markus Klein abandoned the change 10/23/17, 14:28

    Failing to reproduce either. Seems that some other code path is different in v7 and the place is not affected