Review main Merged

54207[BUGFIX] Ignore missing folders from psr-4 definitions

Helmut Hummel CR +2 V +2 Easy +4 −5 updated 09/27/17, 13:51

Commit message

Even when generating an optimized class map for psr-4
classes, Composer gracefully ignores folders defined
in psr-4 autoload section, if they do not exist.

TYPO3 however fails with an exception.

Also change the logic to always generate a class map
for improved class loading performance. This happened
anyway already when calling the autoload generation twice.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Wouter Wolters +1
    • Morton Jonuschat +1
  • Verified V +2
    • Nicole Hummel +2
    • Morton Jonuschat +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1824

  1. Helmut Hummel uploaded patch set 1 09/22/17, 12:17

  2. TYPO3com voted on patch set 1 V +1 09/22/17, 12:32 Completed build in 14m 54s on Fri, 22 Sep, 02:32 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15112

  3. Andreas Allacher updated the commit message in patch set 2 09/22/17, 12:40

  4. Helmut Hummel updated the commit message in patch set 3 09/22/17, 12:43

  5. Andreas Allacher commented on patch set 4 09/22/17, 12:44

    Published edit on patch set 3.
  6. Andreas Allacher commented on patch set 4 09/22/17, 12:44

    Replaced "for for" in comment with "for"
  7. TYPO3com voted on patch set 3 V +1 09/22/17, 12:54 Completed build in 11m 00s on Fri, 22 Sep, 02:54 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15116

  8. TYPO3com voted on patch set 2 V +1 09/22/17, 12:57 Completed build in 16m 09s on Fri, 22 Sep, 02:57 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15115

  9. Nicole Hummel voted on patch set 4 CR +1 09/22/17, 12:58

  10. TYPO3com voted on patch set 4 V +1 09/22/17, 13:01 Completed build in 17m 03s on Fri, 22 Sep, 03:01 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15117

  11. Wouter Wolters voted on patch set 4 CR +1 09/22/17, 13:21

  12. Morton Jonuschat voted on patch set 4 CR +1 09/25/17, 00:10

  13. Sonja Großewinkelmann voted on patch set 4 CR +1 09/25/17, 07:29

  14. Andreas Allacher commented on patch set 4 09/25/17, 07:58

    ClassLoadingInformationGenerator.php:91

    Maybe we should even check if it is a directory (and not just a file or directory) because if the path is a file we cannot really generate a classmap either, can we?
  15. Helmut Hummel uploaded patch set 5 09/25/17, 08:39

  16. Helmut Hummel commented on patch set 4 09/25/17, 08:39

    ClassLoadingInformationGenerator.php:91 Reply

    Done
  17. TYPO3com voted on patch set 5 V -1 09/25/17, 08:55 Completed build in 15m 42s on Mon, 25 Sep, 10:55 AM Test Summary: 1 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15137

  18. TYPO3com voted on patch set 5 V +1 09/25/17, 09:30 Completed build in 1h 06m 19s on Mon, 25 Sep, 11:30 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15137

  19. Morton Jonuschat voted on patch set 5 CR +1 V +1 09/25/17, 13:27

  20. Nicole Hummel commented on patch set 5 CR -1 09/25/17, 13:42

    Please wait till this evening to verify this
  21. Wouter Wolters voted on patch set 5 CR +1 09/26/17, 18:13

  22. Nicole Hummel commented on patch set 5 CR +2 V +2 09/27/17, 13:51

    Sorry for the delay!
  23. Gerrit merged patch set 5 09/27/17, 13:51

  24. Nicole Hummel commented on patch set 6 09/27/17, 13:51

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 47c038b45a077bdc295d098de65628d53bd42e14