Review main Merged

54213[BUGFIX] Fix handling of ClosureFinisher

Andreas Kienast CR +2 V +2 Normal +62 −0 updated 10/06/17, 14:35

Commit message

Check if the incoming optionValue is a closure and return early in such
case.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Björn Jacob +1
    • Wouter Wolters +1
    • Ralf Zimmermann +1
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Björn Jacob +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1316

  1. Andreas Kienast uploaded patch set 1 09/25/17, 08:40

  2. TYPO3com voted on patch set 1 V -1 09/25/17, 08:40 Completed build in 13s on Mon, 25 Sep, 10:40 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15138

  3. Andreas Kienast uploaded patch set 2 09/25/17, 08:41

  4. Andreas Kienast updated the commit message in patch set 3 09/25/17, 08:45

  5. TYPO3com voted on patch set 3 V +1 09/25/17, 09:00 Completed build in 14m 35s on Mon, 25 Sep, 11:00 AM Test Summary: 56769 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15140

  6. Andreas Kienast uploaded patch set 4 09/25/17, 14:25

  7. TYPO3com voted on patch set 4 V +1 09/25/17, 14:39 Completed build in 13m 44s on Mon, 25 Sep, 04:39 PM Test Summary: 56769 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15142

  8. Ralf Zimmermann voted on patch set 4 CR +1 10/06/17, 07:22

  9. Björn Jacob voted on patch set 4 CR +1 10/06/17, 07:22

  10. Jörg Bösche voted on patch set 4 CR +1 10/06/17, 07:59

  11. Wouter Wolters voted on patch set 4 CR +1 10/06/17, 11:29

  12. Björn Jacob voted on patch set 4 V +1 10/06/17, 11:41

  13. Christian Kuhn voted on patch set 4 CR +1 V +1 10/06/17, 11:42

  14. Andreas Kienast voted on patch set 4 CR +2 V +2 10/06/17, 14:34

  15. Gerrit merged patch set 4 10/06/17, 14:35

  16. Andreas Kienast commented on patch set 5 10/06/17, 14:35

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 1298ea9bb7415eabcf0cd298219a8aaa417cc276