54215[TASK] Simplify the Clear temp file section in Install Tool
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1720
-
Georg Ringer uploaded patch set 1 09/26/17, 05:42
-
TYPO3com voted on patch set 1 V +1 09/26/17, 05:57 Completed build in 14m 57s on Tue, 26 Sep, 07:57 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15146
-
Mona Muzaffar voted on patch set 1 CR +1 V +1 09/26/17, 13:55
-
Frank Nägler commented on patch set 1 CR -1 09/26/17, 14:46
This not a good idea, because everyone will search the button which was ever there and can't find it. At least we need an information / hint why the button could be missing. -
Mona Muzaffar commented on patch set 1 09/26/17, 15:44
@Frank, we have the same use case and behavior in 'clear tables'. if a table is empty you won't see a delete button. well, only the 'be_session' table... not saying anything against the hint, just mentioning it. Thought we could find a common solution in another patch since right now, after an action the user gets a callout message but the button remains the same as well, which might be confusing :) -
Mona Muzaffar wrote 11/23/17, 00:12
Removed the following votes: * Code-Review+1 by Mona Muzaffar <mona.muzaffar@gmx.de> * Verified+1 by Mona Muzaffar <mona.muzaffar@gmx.de> -
Sascha Rademacher voted on patch set 1 CR +1 V +1 11/27/17, 09:33
-
Jörg Bösche voted on patch set 1 CR +1 V +1 11/27/17, 10:19
-
Sebastian Hofer voted on patch set 1 CR +1 11/27/17, 20:58
-
Frank Nägler voted on patch set 1 CR 0 11/29/17, 12:32
-
Susi Moog commented on patch set 1 CR -1 11/29/17, 15:55
on it -
Susi Moog uploaded patch set 2 11/29/17, 16:42
-
Benni Mack uploaded patch set 3 11/29/17, 16:47
-
Benni Mack voted on patch set 3 CR +1 V +1 11/29/17, 16:47
-
Christian Kuhn voted on patch set 3 CR -1 11/29/17, 16:50
-
Christian Kuhn voted on patch set 3 CR +1 V +1 11/29/17, 16:52
-
TYPO3com voted on patch set 2 V +1 11/29/17, 16:53 Completed build in 10m 57s on Wed, 29 Nov, 05:53 PM Test Summary: 57000 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16990
-
TYPO3com voted on patch set 3 V +1 11/29/17, 16:58 Completed build in 10m 58s on Wed, 29 Nov, 05:58 PM Test Summary: 57000 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16992
-
Benni Mack voted on patch set 3 CR +2 V +2 11/29/17, 18:05
-
Gerrit merged patch set 3 11/29/17, 18:05