Review main Merged

54216[TASK] Use HTML5 validation for Install Tool test email address

Georg Ringer CR +2 V +2 Easy +10 −7 updated 09/29/17, 15:42

Commit message

Let the browser do the validation for the test email address.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1722

  1. Georg Ringer uploaded patch set 1 09/26/17, 05:57

  2. TYPO3com voted on patch set 1 V +1 09/26/17, 06:11 Completed build in 14m 00s on Tue, 26 Sep, 08:11 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15148

  3. Andreas Kienast voted on patch set 1 CR +1 09/26/17, 06:23

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 09/26/17, 18:12

  5. Mathias Schreiber voted on patch set 1 CR +1 V +1 09/29/17, 14:49

  6. Christian Kuhn commented on patch set 1 CR -1 09/29/17, 15:13

    MailTest.html:37

    the t3js can be removed now.

    MailTest.js:30

    please remove if unused now.
  7. Christian Kuhn voted on patch set 1 V -1 09/29/17, 15:13

  8. Christian Kuhn uploaded patch set 2 09/29/17, 15:14

  9. Mathias Schreiber voted on patch set 2 CR +1 V +1 09/29/17, 15:23

  10. Frank Nägler commented on patch set 2 CR -1 09/29/17, 15:24

    on it
  11. Christian Kuhn uploaded patch set 3 09/29/17, 15:25

  12. Christian Kuhn uploaded patch set 4 09/29/17, 15:25

  13. Christian Kuhn uploaded patch set 5 09/29/17, 15:26

  14. Frank Nägler voted on patch set 5 CR +1 V +1 09/29/17, 15:27

  15. Christian Kuhn voted on patch set 5 CR +1 V +1 09/29/17, 15:27

  16. TYPO3com voted on patch set 2 V +1 09/29/17, 15:28 Completed build in 13m 46s on Fri, 29 Sep, 05:28 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15210

  17. Mathias Schreiber voted on patch set 5 CR +1 V +1 09/29/17, 15:29

  18. TYPO3com voted on patch set 4 V +1 09/29/17, 15:36 Completed build in 10m 43s on Fri, 29 Sep, 05:36 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15212

  19. TYPO3com voted on patch set 3 V -1 09/29/17, 15:38 Completed build in 13m 21s on Fri, 29 Sep, 05:38 PM Test Summary: 1 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15211

  20. TYPO3com voted on patch set 5 V +1 09/29/17, 15:42 Completed build in 15m 38s on Fri, 29 Sep, 05:42 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15213

  21. Frank Nägler voted on patch set 5 CR +2 V +2 09/29/17, 15:42

  22. Gerrit merged patch set 5 09/29/17, 15:42