54225[!!!][TASK] Remove RDCT redirect functionality
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Christian Kuhn +1
-
Verified V +2
- Frank Nägler +2
- Christian Kuhn +1
Issues 1
Files 14
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+0 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+0 −35
- typo3/sysext/core/Documentation/Changelog/master/Breaking-82572-RDCTFunctionalityRemoved.rstnew+63 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −61
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+1 −3
- typo3/sysext/frontend/ext_tables.sql+0 −12
- typo3/sysext/install/Classes/Service/ClearTableService.php+0 −4
- typo3/sysext/install/Classes/Updates/RedirectExtractionUpdate.php2new+146 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php1+6 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+14 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+5 −0
- typo3/sysext/install/ext_localconf.php+2 −0
- typo3/sysext/workspaces/Classes/Hook/PreviewHook.php+1 −2
Review log 1418
-
Benni Mack uploaded patch set 1 09/28/17, 07:52
-
Benni Mack commented on patch set 2 09/28/17, 07:57
Published edit on patch set 1. -
Helmut Hummel commented on patch set 1 09/28/17, 07:58
RedirectExtractionUpdate.php:130what about an early return here if we are in composer mode. as installing the extension will break the TYPO3 on upgrade -
Helmut Hummel commented on patch set 1 09/28/17, 08:05
RedirectExtractionUpdate.php:106ah, ok. everything is fine, as we still offer to deny installation here -
TYPO3com voted on patch set 1 V +1 09/28/17, 08:07 Completed build in 15m 15s on Thu, 28 Sep, 10:07 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15175
-
Helmut Hummel voted on patch set 2 CR +1 09/28/17, 08:09
-
TYPO3com voted on patch set 2 V +1 09/28/17, 08:12 Completed build in 14m 25s on Thu, 28 Sep, 10:12 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15177
-
Susi Moog voted on patch set 2 CR +1 09/29/17, 09:28
-
Christian Kuhn commented on patch set 3 09/29/17, 14:12
Published edit on patch set 2. -
Christian Kuhn commented on patch set 3 09/29/17, 14:12
MethodArgumentDroppedMatcher.php:114This will probably not match since the constructor is usually not called explicitely. We can keep this matcher definition, but should still change the .rst file to 'partiallyScanned' -
TYPO3com voted on patch set 3 V +1 09/29/17, 14:25 Completed build in 12m 50s on Fri, 29 Sep, 04:25 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15203
-
Christian Kuhn voted on patch set 3 V -1 09/29/17, 14:29
-
Frank Nägler commented on patch set 3 V -1 09/29/17, 14:29
extension scanner broken -
Christian Kuhn uploaded patch set 4 09/29/17, 14:31
-
Christian Kuhn voted on patch set 4 CR +1 V +1 09/29/17, 14:32
-
Frank Nägler voted on patch set 4 CR +2 V +2 09/29/17, 14:34
-
Gerrit merged patch set 4 09/29/17, 14:34
-
TYPO3com commented on patch set 4 09/29/17, 14:43 Completed build in 12m 30s on Fri, 29 Sep, 04:43 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15205