Review main Merged Breaking

54225[!!!][TASK] Remove RDCT redirect functionality

Benni Mack CR +2 V +2 Hard +246 −118 updated 09/29/17, 14:43

Commit message

The very legacy RDCT code and the corresponding DB table
"cache_md5params" has been long superseeded and is be
completely moved into its own extension "RDCT" published
on GitHub https://github.com/FriendsOfTYPO3/rdct and in TER.

An upgrade wizard checks if the DB table is filled,
and then installs EXT:rdct.

Note #1: I decided to trigger the hard breaking way,
instead of deprecation as the whole logic (evalution,
static method call in GeneralUtility removed) is interconnected
and only makes sense if all places are there.

Note #2: This functionality has not been in use in the
TYPO3 Core since 4.x - at all, but is in place for
other extensions.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1

Issues 1

Files 14

Review log 1418

  1. Benni Mack uploaded patch set 1 09/28/17, 07:52

  2. Benni Mack commented on patch set 2 09/28/17, 07:57

    Published edit on patch set 1.
  3. Helmut Hummel commented on patch set 1 09/28/17, 07:58

    RedirectExtractionUpdate.php:130

    what about an early return here if we are in composer mode. as installing the extension will break the TYPO3 on upgrade
  4. Helmut Hummel commented on patch set 1 09/28/17, 08:05

    RedirectExtractionUpdate.php:106

    ah, ok. everything is fine, as we still offer to deny installation here
  5. TYPO3com voted on patch set 1 V +1 09/28/17, 08:07 Completed build in 15m 15s on Thu, 28 Sep, 10:07 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15175

  6. Helmut Hummel voted on patch set 2 CR +1 09/28/17, 08:09

  7. TYPO3com voted on patch set 2 V +1 09/28/17, 08:12 Completed build in 14m 25s on Thu, 28 Sep, 10:12 AM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15177

  8. Susi Moog voted on patch set 2 CR +1 09/29/17, 09:28

  9. Christian Kuhn commented on patch set 3 09/29/17, 14:12

    Published edit on patch set 2.
  10. Christian Kuhn commented on patch set 3 09/29/17, 14:12

    MethodArgumentDroppedMatcher.php:114

    This will probably not match since the constructor is usually not called explicitely. We can keep this matcher definition, but should still change the .rst file to 'partiallyScanned'
  11. TYPO3com voted on patch set 3 V +1 09/29/17, 14:25 Completed build in 12m 50s on Fri, 29 Sep, 04:25 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15203

  12. Christian Kuhn voted on patch set 3 V -1 09/29/17, 14:29

  13. Frank Nägler commented on patch set 3 V -1 09/29/17, 14:29

    extension scanner broken
  14. Christian Kuhn uploaded patch set 4 09/29/17, 14:31

  15. Christian Kuhn voted on patch set 4 CR +1 V +1 09/29/17, 14:32

  16. Frank Nägler voted on patch set 4 CR +2 V +2 09/29/17, 14:34

  17. Gerrit merged patch set 4 09/29/17, 14:34

  18. TYPO3com commented on patch set 4 09/29/17, 14:43 Completed build in 12m 30s on Fri, 29 Sep, 04:43 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15205