Review main Merged

54227[BUGFIX] EXT:form - "label" is not set for the FormDefinition class

Ralf Zimmermann CR +2 V +2 Easy +4 −2 updated 10/17/17, 21:48

Commit message

Set the "label" property for the root form element
TYPO3\CMS\Form\Domain\Model\FormDefinition

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Sonja Großewinkelmann +1
    • Frank Nägler +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Ralf Zimmermann uploaded patch set 1 09/28/17, 08:10

  2. TYPO3com voted on patch set 1 V -1 09/28/17, 08:24 Completed build in 14m 37s on Thu, 28 Sep, 10:24 AM Test Summary: 2 of 57122 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15178

  3. TYPO3com voted on patch set 1 V +1 09/29/17, 14:57 Completed build in 7h 02m 01s on Fri, 29 Sep, 04:57 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15178

  4. Frank Nägler voted on patch set 1 CR +1 09/29/17, 15:00

  5. Christian Kuhn voted on patch set 1 CR +1 V +1 09/29/17, 15:07

  6. Christian Kuhn voted on patch set 1 V 0 09/29/17, 15:10

  7. Frank Nägler commented on patch set 1 09/29/17, 15:11

    +1 reading, but I have no idea how to verfiy it. Can you give me an example where to test it?
  8. Sonja Großewinkelmann voted on patch set 1 CR +1 10/16/17, 08:24

  9. Susi Moog voted on patch set 1 CR +1 V +1 10/16/17, 14:47

  10. Christian Kuhn voted on patch set 1 CR +2 V +2 10/17/17, 21:48

  11. Gerrit merged patch set 1 10/17/17, 21:48

  12. Christian Kuhn commented on patch set 2 10/17/17, 21:48

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit e459773b19138ff805dc30ed512071ffd3f45026