Review main Merged

54229[BUGFIX] Fix handling of Storage.Client

Andreas Kienast CR +2 V +2 Easy +11 −2 updated 09/29/17, 14:46

Commit message

The "Storage" module gets the missing "unset" method to remove values
from localStorage. The "isset" method is fixed to determine whether
a value is really existing.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 09/28/17, 13:16

  2. TYPO3com voted on patch set 1 V +1 09/28/17, 13:31 Completed build in 14m 20s on Thu, 28 Sep, 03:31 PM Test Summary: 56763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15181

  3. Benni Mack voted on patch set 1 CR +1 09/28/17, 14:12

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 09/29/17, 14:44

  5. Frank Nägler voted on patch set 1 CR +2 V +2 09/29/17, 14:45

  6. Gerrit merged patch set 1 09/29/17, 14:45

  7. Frank Nägler commented on patch set 2 09/29/17, 14:46

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d56811a7e0c78326f9fbc8d02f708b73069f3ce5