54242[BUGFIX] t3editor: Load TS located in rootline
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1421
-
Andreas Kienast uploaded patch set 1 09/29/17, 21:24
-
Andreas Kienast rebased onto patch set 2 09/29/17, 21:35
-
TYPO3com voted on patch set 1 V +1 09/29/17, 21:39 Completed build in 15m 01s on Fri, 29 Sep, 11:39 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15221
-
TYPO3com voted on patch set 2 V +1 09/29/17, 21:48 Completed build in 12m 47s on Fri, 29 Sep, 11:48 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15223
-
Georg Ringer voted on patch set 2 CR +1 V +1 10/01/17, 19:03
-
Christian Kuhn commented on patch set 2 10/02/17, 14:16
sure this has no side effects? -
Christian Kuhn commented on patch set 2 10/02/17, 14:20
could you elaborate a bit where and how id is used in the target commands? -
Andreas Kienast commented on patch set 2 10/02/17, 15:36
The id is passed to CodeCompletion::processAjaxRequest() (called by TsCodeCompletion.loadExtTemplatesAsync()). With that information, the editor is able to "climb up" the rootline and attach any TS stored in "config" and "include_static_file". I didn't spot any side effects so far. -
Christian Kuhn commented on patch set 2 CR -1 10/02/17, 22:07
i'll -1 this for now. i think the id handling should be explicit. will talk to andy about details. -
Andreas Kienast uploaded patch set 3 10/03/17, 16:20
-
Andreas Kienast uploaded patch set 4 10/03/17, 16:21
-
Andreas Kienast uploaded patch set 5 10/03/17, 16:31
-
TYPO3com voted on patch set 3 V +1 10/03/17, 16:34 Completed build in 13m 50s on Tue, 3 Oct, 06:34 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15310
-
TYPO3com voted on patch set 4 V +1 10/03/17, 16:36 Completed build in 14m 30s on Tue, 3 Oct, 06:36 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15311
-
TYPO3com voted on patch set 5 V +1 10/03/17, 16:44 Completed build in 12m 18s on Tue, 3 Oct, 06:44 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15312
-
Christian Kuhn updated the commit message in patch set 6 10/03/17, 18:56
-
Christian Kuhn voted on patch set 6 CR +1 V +1 10/03/17, 18:57
-
TYPO3com voted on patch set 6 V -1 10/03/17, 19:09 Completed build in 12m 57s on Tue, 3 Oct, 09:09 PM Test Summary: 1 of 57123 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15313
-
TYPO3com voted on patch set 6 V +1 10/03/17, 19:15 Completed build in 31m 14s on Tue, 3 Oct, 09:15 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15313
-
Wouter Wolters voted on patch set 6 CR +2 V +2 10/04/17, 18:22
-
Gerrit merged patch set 6 10/04/17, 18:22