54250[BUGFIX] Add support for t3:// syntax to FileCollector
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Wouter Wolters +1
- Frans Saris +1
- Jörg Bösche +1
- Andreas Kienast +1
-
Verified V +2
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1114
-
Jigal van Hemert uploaded patch set 1 10/01/17, 11:08
-
TYPO3com voted on patch set 1 V +1 10/01/17, 11:21 Completed build in 12m 42s on Sun, 1 Oct, 01:21 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15234
-
Andreas Kienast updated the commit message in patch set 2 10/01/17, 12:18
-
Andreas Kienast voted on patch set 2 CR +1 V +1 10/01/17, 12:18
-
TYPO3com voted on patch set 2 V -1 10/01/17, 12:30 Completed build in 12m 17s on Sun, 1 Oct, 02:30 PM Test Summary: 1 of 57123 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15237
-
TYPO3com voted on patch set 2 V +1 10/01/17, 13:04 Completed build in 58m 19s on Sun, 1 Oct, 03:04 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15237
-
Frans Saris commented on patch set 2 CR +1 10/01/17, 17:43
Next step the fileCollection record/TCA ;) -
Wouter Wolters voted on patch set 2 CR +1 10/03/17, 07:06
-
Benni Mack commented on patch set 2 10/03/17, 19:53
Just out of curiousity - why would sbdy do that? I mean, the URN is a "link", not a "folderIdentifier" (1:/myfolder/) -
Jigal van Hemert commented on patch set 2 10/04/17, 05:24
> Just out of curiousity - why would sbdy do that? I mean, the URN is > a "link", not a "folderIdentifier" (1:/myfolder/) In TCA and flexforms the link browser is the only way to select a folder. (In TCA you can make a file reference but since it links a file to a record this won't work in flexform sections.) In previous releases the link browser would provide the path to a file or folder and later an identifier as a link but since v8 it provides a t3:// link. Fields that were used to point to a folder (or file, but that was fixed earlier) could no longer be used. The case where I found this particular issue was a field to select a folder that was later passed to the FilesProcessor to eventually generate a gallery. -
Benni Mack commented on patch set 2 CR +2 10/04/17, 05:25
thx! -
Jörg Bösche voted on patch set 2 CR +1 10/05/17, 06:05
-
Benni Mack voted on patch set 2 V +2 10/06/17, 15:23
-
Gerrit merged patch set 2 10/06/17, 15:23