Review TYPO3_8-7 Merged

54252[CLEANUP] Review comment of PageRepository::getPage()

Benni Mack CR +2 V +2 Easy +25 −7 updated 10/02/17, 05:08

Commit message

Note:

Type hints are not trivial to add to the signature. Although the
method always returns an array, there are unit tests that make use
of the assumption that the method is allowed to return null. Fixing
this goes beyond the goals of this ticket.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 10/02/17, 04:53

    Cherry Picked from branch master.
  2. Benni Mack voted on patch set 1 CR +2 V +2 10/02/17, 04:53

  3. Gerrit merged patch set 1 10/02/17, 04:53

  4. TYPO3com commented on patch set 1 10/02/17, 05:08 Completed build in 15m 27s on Mon, 2 Oct, 07:08 AM Test Summary: 57519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-991