Review main Merged

54255[FOLLOWUP][TASK] Remove migrated TYPO3_CONF_VARS/SYS/setDBinit

Benni Mack CR +2 V +2 Easy +8 −5 updated 10/02/17, 22:11

Commit message

This patch removes the obsolete "setDBinit" option which was migrated
in TYPO3 v8.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1014

  1. Benni Mack uploaded patch set 1 10/02/17, 08:00

  2. TYPO3com voted on patch set 1 V +1 10/02/17, 08:14 Completed build in 13m 39s on Mon, 2 Oct, 10:14 AM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15251

  3. Benni Mack uploaded patch set 2 10/02/17, 09:04

  4. TYPO3com voted on patch set 2 V -1 10/02/17, 09:16 Completed build in 12m 12s on Mon, 2 Oct, 11:16 AM Test Summary: 1 of 57123 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15258

  5. TYPO3com voted on patch set 2 V +1 10/02/17, 09:35 Completed build in 43m 06s on Mon, 2 Oct, 11:35 AM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15258

  6. Wouter Wolters voted on patch set 2 CR +1 10/02/17, 12:23

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 10/02/17, 13:12

  8. Andreas Kienast commented on patch set 2 CR -1 10/02/17, 13:32

    install/Classes/SystemEnvironment/DatabasePlatform/MySqlCheck.php still mentions setDBinit
  9. Benni Mack uploaded patch set 3 10/02/17, 19:02

  10. TYPO3com voted on patch set 3 V +1 10/02/17, 19:15 Completed build in 13m 02s on Mon, 2 Oct, 09:15 PM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15274

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 10/02/17, 20:03

  12. Wouter Wolters voted on patch set 3 CR +1 10/02/17, 20:26

  13. Benni Mack voted on patch set 3 CR +2 V +2 10/02/17, 22:11

  14. Gerrit merged patch set 3 10/02/17, 22:11