Review main Merged

54266[TASK] Raise BE user session timeout to 8 hours

Benni Mack CR +2 V +2 Easy +3 −3 updated 10/03/17, 11:19

Commit message

The current limit of an inactive user of 1 hour is not practical for a regular
editor. Instead, a default value of 8 hours fits more to a current work day.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 910

  1. Benni Mack uploaded patch set 1 10/02/17, 23:24

  2. Christian Kuhn commented on patch set 1 CR +1 V +1 10/02/17, 23:29

    yes please.
  3. TYPO3com voted on patch set 1 V +1 10/02/17, 23:38 Completed build in 14m 30s on Tue, 3 Oct, 01:38 AM Test Summary: 56764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15287

  4. Wouter Wolters voted on patch set 1 CR +1 10/03/17, 06:30

  5. Tymoteusz Motylewski commented on patch set 1 10/03/17, 08:12

    would be nice to get a green light from Security Team also
  6. Markus Klein voted on patch set 1 CR +2 V +2 10/03/17, 09:41

  7. Markus Klein commented on patch set 1 10/03/17, 09:42

    Don't think this is sec critical.
  8. Gerrit merged patch set 1 10/03/17, 09:42

  9. Frans Saris commented on patch set 2 10/03/17, 11:00

    IMO this security related. Now it's even more important to instruct editors to logout.
  10. Markus Klein commented on patch set 2 10/03/17, 11:19

    > IMO this security related Disagree actually. 1.) "Teach people to log out". Well they hopefully know that from their online banking. Other than that this is not a TYPO3 related thing 2.) If tab is only closed an attacked can access the device anytime. No matter what your timeout is. The risk is the same.