Review TYPO3_8-7 Merged

54308[BUGFIX] Do not GROUP BY alias in WorkspaceService

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/06/17, 10:53

Commit message

GROUP BY statements are in general evaluated before
SELECT statements. If a DBMS does not implement additional
logic to resolve aliases defined in SELECTS before grouping
the statement will fail. Currently both MSSQL as well as ORACLE
lack these additional implementations. To be safe we should
group by the non-aliased columns.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 10/06/17, 10:38

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/06/17, 10:50 Completed build in 11m 50s on Fri, 6 Oct, 12:50 PM Test Summary: 57519 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1023

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 10/06/17, 10:53

  4. Gerrit merged patch set 1 10/06/17, 10:53