Review main Merged Breaking

54312[!!!][TASK] Deprecate ext:backend class AbstractModule

Christian Kuhn CR +2 V +2 Normal +184 −44 updated 10/06/17, 15:04

Commit message

The internal / experimental class ext:backend/Module/AbstractModule
doesn't do much useful stuff: It only instantiates ModuleTemplate
in it's constructor which forces all inheriting classes to call
parent::__construct(). The processRequest() method with its
dispatcher code is never used in core, but superseeded by routing
configuration via Configuration/Backend/Routes.php.

The patch removes given AbstractModule usages and markes the
class as deprecated. The patch is slightly breaking in cases
an extension extends AbstractWizardController and additionally
uses the initialized moduleTemplate property.

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 21

Show 1 more file

Review log 1014

  1. Christian Kuhn uploaded patch set 1 10/06/17, 14:15

  2. TYPO3com voted on patch set 1 V -1 10/06/17, 14:16 Completed build in 10s on Fri, 6 Oct, 04:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15419

  3. Christian Kuhn uploaded patch set 2 10/06/17, 14:16

  4. TYPO3com voted on patch set 2 V +1 10/06/17, 14:26 Completed build in 09m 25s on Fri, 6 Oct, 04:26 PM Test Summary: 56580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15420

  5. Andreas Kienast commented on patch set 2 10/06/17, 14:31

    Breaking-82689-BackendAbstractWizardControllerNotExtendsAbstractModule.rs:1

    File name is broken, extension is "rs"
  6. Christian Kuhn commented on patch set 2 CR -1 10/06/17, 14:37

    fiddling with details
  7. Christian Kuhn commented on patch set 2 10/06/17, 14:37

    Breaking-82689-BackendAbstractWizardControllerNotExtendsAbstractModule.rs:1 Reply

    Done
  8. Christian Kuhn uploaded patch set 3 10/06/17, 14:39

  9. Andreas Kienast uploaded patch set 4 10/06/17, 14:46

  10. Andreas Kienast voted on patch set 4 CR +1 V +1 10/06/17, 14:46

  11. TYPO3com voted on patch set 3 V +1 10/06/17, 14:51 Completed build in 12m 07s on Fri, 6 Oct, 04:51 PM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15422

  12. TYPO3com voted on patch set 4 V +1 10/06/17, 14:55 Completed build in 09m 48s on Fri, 6 Oct, 04:55 PM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15423

  13. Benni Mack voted on patch set 4 CR +2 V +2 10/06/17, 15:04

  14. Gerrit merged patch set 4 10/06/17, 15:04