54318[!!!][TASK] Clean up graphical functions library
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Susi Moog +1
-
Verified V +2
- Christian Kuhn +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php1+64 −92
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+0 −1
- typo3/sysext/core/Classes/Resource/Processing/LocalPreviewHelper.php+0 −1
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −1
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+2 −6
- typo3/sysext/core/Documentation/Changelog/master/Breaking-82768-ConfigurationOptionsForImageManipulationPHPAPI.rst2new+63 −0
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+1 −1
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+4 −5
Review log 1418
-
Benni Mack uploaded patch set 1 10/08/17, 12:29
-
TYPO3com voted on patch set 1 V +1 10/08/17, 12:40 Completed build in 10m 37s on Sun, 8 Oct, 02:40 PM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15440
-
Benni Mack uploaded patch set 2 10/16/17, 06:02
-
TYPO3com voted on patch set 2 V -1 10/16/17, 06:10 Completed build in 08m 22s on Mon, 16 Oct, 08:10 AM Test Summary: 1 of 56971 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15655
-
TYPO3com voted on patch set 2 V +1 10/16/17, 06:34 Completed build in 40m 50s on Mon, 16 Oct, 08:34 AM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15655
-
Jörg Bösche voted on patch set 2 CR +1 10/16/17, 07:25
-
Henning Liebe voted on patch set 2 CR +1 10/16/17, 07:59
-
Jan Stockfisch voted on patch set 2 CR +1 10/16/17, 08:48
-
Georg Ringer commented on patch set 2 10/16/17, 11:36
-
Benni Mack commented on patch set 2 10/16/17, 12:20
Breaking-82768-ConfigurationOptionsForImageManipulationPHPAPI.rst:41Replywell, if you look at the previous code, -1 and 0 behaved the same way, so there is actually no change in functionality. Could you tell me what I should explain there? Maybe just what I wrote... (thinking about it) -
Christian Kuhn voted on patch set 2 CR +1 V +1 10/16/17, 13:14
-
Christian Kuhn voted on patch set 2 CR -1 10/16/17, 13:20
-
Susi Moog commented on patch set 2 CR -1 10/16/17, 13:24
imageFileExt is still used as string in \TYPO3\CMS\Frontend\Imaging\GifBuilder. -
Susi Moog uploaded patch set 3 10/16/17, 13:35
-
TYPO3com voted on patch set 3 V +1 10/16/17, 13:43 Completed build in 08m 36s on Mon, 16 Oct, 03:43 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15674
-
Susi Moog voted on patch set 3 CR +1 V +1 10/16/17, 13:49
-
Christian Kuhn commented on patch set 3 CR +2 V +2 10/16/17, 14:08
GraphicalFunctions.php:120still used in ext:install EnvironmentControlrer -
Gerrit merged patch set 3 10/16/17, 14:08
Breaking-82768-ConfigurationOptionsForImageManipulationPHPAPI.rst:41