Review main Merged Breaking

54318[!!!][TASK] Clean up graphical functions library

Benni Mack CR +2 V +2 Normal +135 −107 updated 10/16/17, 14:08

Commit message

Properties which are only accessed inside of
GraphicalFunctions and should remain inside are marked
as protected, are migrated to arrays (to avoid inList calls
instead of in_array()), removed or renamed to remove
classic kasper's-style double negation namings.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1418

  1. Benni Mack uploaded patch set 1 10/08/17, 12:29

  2. TYPO3com voted on patch set 1 V +1 10/08/17, 12:40 Completed build in 10m 37s on Sun, 8 Oct, 02:40 PM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15440

  3. Benni Mack uploaded patch set 2 10/16/17, 06:02

  4. TYPO3com voted on patch set 2 V -1 10/16/17, 06:10 Completed build in 08m 22s on Mon, 16 Oct, 08:10 AM Test Summary: 1 of 56971 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15655

  5. TYPO3com voted on patch set 2 V +1 10/16/17, 06:34 Completed build in 40m 50s on Mon, 16 Oct, 08:34 AM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15655

  6. Jörg Bösche voted on patch set 2 CR +1 10/16/17, 07:25

  7. Henning Liebe voted on patch set 2 CR +1 10/16/17, 07:59

  8. Jan Stockfisch voted on patch set 2 CR +1 10/16/17, 08:48

  9. Georg Ringer commented on patch set 2 10/16/17, 11:36

    Breaking-82768-ConfigurationOptionsForImageManipulationPHPAPI.rst:41

    the changed configuration should be explained as well
  10. Benni Mack commented on patch set 2 10/16/17, 12:20

    Breaking-82768-ConfigurationOptionsForImageManipulationPHPAPI.rst:41 Reply

    well, if you look at the previous code, -1 and 0 behaved the same way, so there is actually no change in functionality. Could you tell me what I should explain there? Maybe just what I wrote... (thinking about it)
  11. Christian Kuhn voted on patch set 2 CR +1 V +1 10/16/17, 13:14

  12. Christian Kuhn voted on patch set 2 CR -1 10/16/17, 13:20

  13. Susi Moog commented on patch set 2 CR -1 10/16/17, 13:24

    imageFileExt is still used as string in \TYPO3\CMS\Frontend\Imaging\GifBuilder.
  14. Susi Moog uploaded patch set 3 10/16/17, 13:35

  15. TYPO3com voted on patch set 3 V +1 10/16/17, 13:43 Completed build in 08m 36s on Mon, 16 Oct, 03:43 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15674

  16. Susi Moog voted on patch set 3 CR +1 V +1 10/16/17, 13:49

  17. Christian Kuhn commented on patch set 3 CR +2 V +2 10/16/17, 14:08

    GraphicalFunctions.php:120

    still used in ext:install EnvironmentControlrer
  18. Gerrit merged patch set 3 10/16/17, 14:08