Review main Merged

54323[TASK] Deprecate second argument of GeneralUtility::mkdir_deep()

Benni Mack CR +2 V +2 Normal +64 −19 updated 10/09/17, 09:27

Commit message

The syntax is very confusing, and the second argument is not necessarily
needed - most of the TYPO3 Core code uses only the first argument.

In order to streamline the API the second method argument is deprecated
but still works as before.

Review

  • Code review CR +2
    • Susi Moog +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Jörg Bösche +1
  • Verified V +2
    • Susi Moog +2
    • Georg Ringer +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1015

  1. Benni Mack uploaded patch set 1 10/08/17, 13:16

  2. TYPO3com voted on patch set 1 V +1 10/08/17, 13:27 Completed build in 10m 56s on Sun, 8 Oct, 03:27 PM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15446

  3. Benni Mack uploaded patch set 2 10/08/17, 13:57

  4. TYPO3com voted on patch set 2 V +1 10/08/17, 14:07 Completed build in 09m 27s on Sun, 8 Oct, 04:07 PM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15452

  5. Benni Mack commented on patch set 3 10/09/17, 07:04

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V -1 10/09/17, 07:04 Completed build in 11s on Mon, 9 Oct, 09:04 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15465

  7. Benni Mack commented on patch set 4 10/09/17, 07:05

    Published edit on patch set 3.
  8. TYPO3com voted on patch set 4 V +1 10/09/17, 07:19 Completed build in 13m 47s on Mon, 9 Oct, 09:19 AM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15466

  9. Benni Mack uploaded patch set 5 10/09/17, 08:37

  10. Georg Ringer voted on patch set 5 CR +1 V +1 10/09/17, 08:42

  11. Wouter Wolters voted on patch set 5 CR +1 10/09/17, 08:46

  12. TYPO3com voted on patch set 5 V +1 10/09/17, 08:47 Completed build in 09m 51s on Mon, 9 Oct, 10:47 AM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15470

  13. Jörg Bösche voted on patch set 5 CR +1 V +1 10/09/17, 08:48

  14. Susi Moog voted on patch set 5 CR +2 V +2 10/09/17, 09:27

  15. Gerrit merged patch set 5 10/09/17, 09:27