54328[FEATURE] Add readonly and required attributes to TextareaViewHelper
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Mathias Schreiber +1
-
Verified V +2
- Benni Mack +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 4757
Show 2832 earlier messages
-
Raphael Graf uploaded patch set 1 10/08/17, 18:19
-
TYPO3com voted on patch set 1 V -1 10/08/17, 18:29 Completed build in 09m 25s on Sun, 8 Oct, 08:29 PM Test Summary: 12 of 56945 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15461
-
Raphael Graf uploaded patch set 2 10/08/17, 19:22
-
TYPO3com voted on patch set 2 V +1 10/08/17, 19:32 Completed build in 09m 50s on Sun, 8 Oct, 09:32 PM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15462
-
Jörg Bösche voted on patch set 2 CR +1 10/09/17, 07:24
-
Mathias Brodala commented on patch set 2 10/09/17, 07:36
-
Jan Stockfisch commented on patch set 2 CR -1 10/09/17, 09:05
TextareaViewHelper.php:51ReplyUsing `string` here is IMHO the right way to do. It's used to pass it's content straight to the tag itself. Mean `readonly="readonly"`can be achieved without any more code.TextareaViewHelper.php:55`registerTagAttribute()` with type `string` should be used instead for the reason of consistency. Also then the newly added code below can be droped. -
Mathias Brodala commented on patch set 2 CR -1 10/09/17, 09:08
TextareaViewHelper.php:51ReplyI'm fine either way as long as it's consistent. -
Raphael Graf commented on patch set 2 10/09/17, 10:31
I think `registerTagAttribute()` with type `string` would be fine, but then, this should be applied to Textfield and SelectViewhelper too. Note that this would significantly change the behaviour of required="0". Maybe it would be better to do this conversion in a separate commit. -
Mathias Brodala commented on patch set 2 10/09/17, 10:39
TextareaViewHelper.php:51ReplyI think one considerable advantage of "bool" over "string" is that you can put some logic into the attribute to decide whether it should be added at all. With "string" this is not possible. Also having to write something like foo="foo" already feels braindead in native (X)HTML, so Fluid should do better. ;-) -
Raphael Graf commented on patch set 2 10/09/17, 10:51
> (1 comment) (I slightly prefer "string" because it's simpler and you can still use required="" if the attribute should be omitted.) -
Jan Stockfisch commented on patch set 2 10/09/17, 11:24
> (1 comment) Agreed @mathias. TBH, foo="foo" looks totaly weird to me, so Fluid should definitely do better. But refactoring that seems not to be part of this feature. So how about be consistent in this one using "string" and refatctor the arguments in another one? -
Mathias Brodala commented on patch set 2 10/09/17, 11:49
> > (1 comment) > > Agreed @mathias. TBH, foo="foo" looks totaly weird to me, so Fluid > should definitely do better. But refactoring that seems not to be > part of this feature. > > So how about be consistent in this one using "string" and refatctor > the arguments in another one? Yes, this would be the preferred route. If these arguments are changed to boolean later, existing string values would still be valid. -
Raphael Graf commented on patch set 2 10/09/17, 12:25
Agreed @mathias. (By the way: foo="foo" is what TYPO3 does with boolean attributes, as far as I know, you are free to write foo="1" or foo="true" for string types like 'required';) -
Sascha Rademacher commented on patch set 2 CR +1 10/23/17, 08:36
Looks good to me. Current Version is consistent with TextfieldViewHelper -
Jörg Bösche voted on patch set 2 V +1 11/20/17, 10:09
-
Susi Moog commented on patch set 2 01/28/18, 13:26
ping - @Mathias: are you fine with the explanation in the comments? What is missing here to continue? -
Susi Moog wrote 01/28/18, 13:26
Removed reviewer Susanne Moog. -
Timo Pfeffer commented on patch set 2 01/30/18, 21:14
TextareaViewHelper.php:51ReplyI'm totally agree with Mathias. Just because many people are using the required="required" notation in html doesn't mean that fluid should handle this on the same way. In my oppinion required="1" or required="true" is better readable and makes more sense. So I would use bool here.TextareaViewHelper.php:55ReplyIn my opinion bool is more consistent and more strict. So I would keep here the bool. -
Mathias Schreiber commented on patch set 2 02/04/18, 11:02
can we move on here? The change is pretty straight forward and currently blocked. -
Timo Pfeffer commented on patch set 3 02/04/18, 15:46
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 02/04/18, 15:52 Completed build in 05m 39s on Sun, 4 Feb, 04:52 PM Test Summary: 30369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18883
-
Mathias Schreiber commented on patch set 3 02/04/18, 16:09
TextareaViewHelper.php:51I hate to be a pain, but I can't find the place in the code that will actually add the readonly attribute :) -
Andreas Kienast commented on patch set 3 CR -1 02/04/18, 17:36
On it, and the ReST is missing.TextareaViewHelper.php:51Reply UnresolvedIIRC this is automatically done as the tag is registered as a tagAttribute. I will try to add a test. -
Andreas Kienast uploaded patch set 4 02/04/18, 17:50
-
TYPO3com voted on patch set 4 V +1 02/04/18, 17:56 Completed build in 06m 53s on Sun, 4 Feb, 06:56 PM Test Summary: 30372 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18897
-
Wouter Wolters voted on patch set 4 CR +1 02/04/18, 19:43
-
Jan Stockfisch voted on patch set 4 CR +1 02/04/18, 19:47
-
Mathias Schreiber commented on patch set 4 02/04/18, 21:05
Quick question... what would you expect to happen if I used this code: <f:form.textarea name="foo" readonly="false" /> -
Mathias Schreiber commented on patch set 4 V -1 CR -1 02/04/18, 21:13
setting the readonly boolean to false results in the attribute being written, making the textarea readonly. -
Marcel Ulbrich rebased onto patch set 5 02/04/18, 21:16
-
Marcel Ulbrich uploaded patch set 6 02/04/18, 21:19
-
Mathias Schreiber commented on patch set 6 V +1 CR +1 02/04/18, 21:21
Thanks Marcel, that does the trick -
Marcel Ulbrich voted on patch set 6 V +1 CR +1 02/04/18, 21:21
-
Jörg Bösche voted on patch set 6 V +1 CR +1 02/04/18, 21:22
-
TYPO3com voted on patch set 6 V -1 02/04/18, 21:25 Completed build in 05m 49s on Sun, 4 Feb, 10:25 PM Test Summary: 3 of 30548 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18910
-
TYPO3com voted on patch set 5 V +1 02/04/18, 21:26 Completed build in 09m 21s on Sun, 4 Feb, 10:26 PM Test Summary: 30393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18909
-
Mathias Schreiber uploaded patch set 7 02/04/18, 21:54
-
TYPO3com voted on patch set 7 V +1 02/04/18, 22:00 Completed build in 05m 44s on Sun, 4 Feb, 11:00 PM Test Summary: 30402 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18912
-
Mathias Schreiber commented on patch set 7 V +1 CR +1 02/04/18, 22:03
jetz aber... -
Marcel Ulbrich voted on patch set 7 V +1 CR +1 02/04/18, 22:04
-
Jörg Bösche voted on patch set 7 V +1 CR +1 02/05/18, 08:11
-
Helmut Hummel commented on patch set 7 CR -1 02/05/18, 09:22
TextareaViewHelper.php:74afaik fluid cast bool arguments to bool. there would be no way this is a string here then -
Jan Stockfisch commented on patch set 7 CR -1 02/05/18, 09:49
TextareaViewHelper.php:74ReplyYes, Fluid does cast them. Means the first comparison's are always `false`. -
Mathias Schreiber uploaded patch set 8 02/05/18, 09:53
-
Mathias Schreiber commented on patch set 8 02/05/18, 09:54
> Patch Set 7: Code-Review-1 > > (1 comment) Adjusted the tests. -
TYPO3com voted on patch set 8 V +1 02/05/18, 10:04 Completed build in 10m 43s on Mon, 5 Feb, 11:04 AM Test Summary: 30401 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18917
-
Jan Stockfisch voted on patch set 8 V +1 CR +1 02/05/18, 10:08
-
Reiner Teubner commented on patch set 8 02/05/18, 15:36
Should we have a look at the other VH? Maybe it would be useful to update them too?TextareaViewHelper.php:53UnresolvedIn f:form.textfield or password 'readonly' is a 'string'. I prefer here to do same. -
Mathias Schreiber commented on patch set 8 V -1 CR -1 02/05/18, 17:22
will fix. For consistencies sake -
Mathias Schreiber uploaded patch set 9 02/05/18, 17:27
-
TYPO3com voted on patch set 9 V +1 02/05/18, 17:33 Completed build in 05m 43s on Mon, 5 Feb, 06:33 PM Test Summary: 30422 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18948
-
Mathias Schreiber uploaded patch set 10 02/05/18, 18:11
-
TYPO3com voted on patch set 10 V +1 02/05/18, 18:17 Completed build in 05m 43s on Mon, 5 Feb, 07:17 PM Test Summary: 30422 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18950
-
Mathias Schreiber voted on patch set 10 V +1 CR +1 02/11/18, 00:22
-
Benni Mack voted on patch set 10 V +2 CR +2 02/11/18, 00:23
-
Benni Mack merged patch set 11 02/11/18, 00:23
TextareaViewHelper.php:51