Review main Merged

54341[BUGFIX] Record list: Fix condition for unlimited records

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 10/11/17, 07:11

Commit message

This patch fixes a condition that fails when a CSV export in the record
list is requested. The maximum limit of records is set, if `$iLimit` is
larger than 0 to avoid a `LIMIT 0` query.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stephan Großberndt +1
    • Tymoteusz Motylewski +1
    • Henning Liebe +1
    • Jörg Bösche +1
  • Verified V +2
    • Frank Nägler +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1114

  1. Andreas Kienast uploaded patch set 1 10/09/17, 13:36

  2. Christian Kuhn updated the commit message in patch set 2 10/09/17, 13:44

  3. TYPO3com voted on patch set 1 V +1 10/09/17, 13:45 Completed build in 08m 58s on Mon, 9 Oct, 03:45 PM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15480

  4. Andreas Kienast uploaded patch set 3 10/09/17, 13:48

  5. TYPO3com voted on patch set 2 V +1 10/09/17, 13:54 Completed build in 10m 34s on Mon, 9 Oct, 03:54 PM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15481

  6. TYPO3com voted on patch set 3 V +1 10/09/17, 13:58 Completed build in 10m 18s on Mon, 9 Oct, 03:58 PM Test Summary: 56586 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15482

  7. Stephan Großberndt voted on patch set 3 CR +1 10/09/17, 14:00

  8. Henning Liebe voted on patch set 3 CR +1 10/10/17, 05:51

  9. Jörg Bösche voted on patch set 3 CR +1 10/10/17, 07:15

  10. Tymoteusz Motylewski voted on patch set 3 CR +1 V +1 10/10/17, 11:22

  11. Christian Kuhn commented on patch set 3 10/10/17, 18:29

    pinged frank for a review here.
  12. Frank Nägler commented on patch set 3 CR -1 10/10/17, 21:25

    temp -1 will talk to Andy and Lolli about the solution. Generell it must be fixed.
  13. Frank Nägler voted on patch set 3 CR +2 V +2 10/11/17, 07:11

  14. Gerrit merged patch set 3 10/11/17, 07:11