Review main Merged

54347[BUGFIX] Avoid corrupted session when IP changes

Markus Klein CR +2 V +2 Easy +10 −6 updated 10/10/17, 15:06

Commit message

If the IP of the client changes and is not within the
lockIP range anymore a new session is now created.

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Franz Holzinger +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Markus Klein uploaded patch set 1 10/10/17, 09:01

  2. TYPO3com voted on patch set 1 V +1 10/10/17, 09:09 Completed build in 08m 37s on Tue, 10 Oct, 11:09 AM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15511

  3. Benni Mack commented on patch set 2 10/10/17, 09:18

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 10/10/17, 09:26 Completed build in 08m 06s on Tue, 10 Oct, 11:26 AM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15512

  5. Susi Moog voted on patch set 2 CR +1 10/10/17, 10:10

  6. Susi Moog voted on patch set 2 V +1 10/10/17, 10:17

  7. Franz Holzinger commented on patch set 2 V +1 10/10/17, 11:58

    This fixes the session error.
  8. Andreas Kienast voted on patch set 2 CR +1 10/10/17, 12:33

  9. Benni Mack voted on patch set 2 CR +2 V +2 10/10/17, 15:06

  10. Gerrit merged patch set 2 10/10/17, 15:06

  11. Benni Mack commented on patch set 3 10/10/17, 15:06

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 68613962924dca1f95b666bac1c5082f16d29d8f