54348[BUGFIX] Support fragment/section for record links
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Alexander Stehlik +1
- Frank Nägler +1
- Stefan Neufeind +1
- Jörg Bösche +1
- Sebastian Hofer +1
-
Verified V +2
- Andreas Wolf +2
- Alexander Stehlik +1
- Stefan Neufeind +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2833
Show 58 earlier messages
-
Mathias Brodala uploaded patch set 1 10/10/17, 10:58
-
TYPO3com voted on patch set 1 V +1 10/10/17, 11:08 Completed build in 09m 31s on Tue, 10 Oct, 01:08 PM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15517
-
Andreas Kienast voted on patch set 1 CR +1 10/10/17, 11:10
-
Mathias Brodala uploaded patch set 2 10/10/17, 12:04
-
Mathias Brodala updated the commit message in patch set 3 10/10/17, 12:06
-
TYPO3com voted on patch set 2 V +1 10/10/17, 12:16 Completed build in 11m 31s on Tue, 10 Oct, 02:16 PM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15522
-
TYPO3com voted on patch set 3 V +1 10/10/17, 12:18 Completed build in 12m 20s on Tue, 10 Oct, 02:18 PM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15523
-
Jörg Bösche updated the commit message in patch set 4 10/14/17, 21:22
-
Jörg Bösche voted on patch set 4 CR +1 10/14/17, 21:23
-
TYPO3com voted on patch set 4 V +1 10/14/17, 21:31 Completed build in 08m 46s on Sat, 14 Oct, 11:31 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15650
-
Sonja Großewinkelmann voted on patch set 4 CR +1 10/16/17, 07:18
-
Susi Moog commented on patch set 4 10/16/17, 17:39
how can we test this? -
Georg Ringer commented on patch set 4 10/16/17, 17:59
RecordLinkHandler.php:46is there a reason why not just using '#' . $parameters['fragment'];? -
Mathias Brodala commented on patch set 4 10/17/17, 10:19
RecordLinkHandler.php:46ReplyI just followed the code style established above. -
Mathias Brodala commented on patch set 4 10/17/17, 10:23
> how can we test this? You'll need a custom recordlist linkhandler registered in TCEMAIN.linkHandler which adds a "lparams" field similar to this: https://github.com/TYPO3/TYPO3.CMS/blob/ae18caad69fee5920adeb82d13ba98ba58cadf24/typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php#L546-L556 -
Mathias Brodala commented on patch set 4 CR -1 10/17/17, 10:24
I'll need to have another look to ensure this also works properly for link fields, not only RTE links. -
Mathias Schreiber commented on patch set 4 03/01/18, 21:01
What's the result of the 4month thinking period? :) -
Anja Leichsenring commented on patch set 4 04/14/18, 14:35
ping? anything doing? -
Mathias Brodala commented on patch set 4 06/06/18, 13:32
I'll at least rebase. -
Mathias Brodala uploaded patch set 5 06/06/18, 13:40
-
TYPO3com voted on patch set 5 V +1 06/06/18, 13:49 Completed build in 08m 58s on Wed, 6 Jun, 03:49 PM Test Summary: 31143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24088
-
Frank Nägler commented on patch set 5 06/08/18, 12:36
RecordLinkHandler.php:46a simple string concatenation would also work here ;) -
Mathias Brodala commented on patch set 5 06/08/18, 13:19
RecordLinkHandler.php:46ReplySure, but please see my answer to exactly this remark on October 17th last year. ;-) -
Frank Nägler commented on patch set 5 06/08/18, 13:23
RecordLinkHandler.php:46Replyok, no problem :D -
Frank Nägler voted on patch set 5 CR +1 06/08/18, 14:45
-
Jörg Bösche voted on patch set 5 CR +1 06/11/18, 16:00
-
Stefan Neufeind commented on patch set 5 V +1 CR +1 06/11/18, 17:32
Works for me with a hand-added fragment in a record-link. Without the patch "parameters:fragment" for a typolink is empty. Should the RecordLinkHandler also have an input for a fragment? But that can come as a separate change (maybe for master only), if we desire so. -
Mathias Brodala commented on patch set 5 06/12/18, 07:16
> Works for me with a hand-added fragment in a record-link. Without > the patch "parameters:fragment" for a typolink is empty. Heh, I didn't think of this very easy test, thanks. ;-) > Should the RecordLinkHandler also have an input for a fragment? But > that can come as a separate change (maybe for master only), if we > desire so. I agree. -
Sebastian Hofer voted on patch set 5 CR +1 06/22/18, 22:20
-
Alexander Stehlik commented on patch set 5 V +1 CR +1 06/22/18, 23:36
Works like expected. A hint: when the fragment is numeric TypoLink will prefix it with a "c". -
Andreas Wolf voted on patch set 5 V +2 CR +2 06/23/18, 09:25
-
Andreas Wolf merged patch set 6 06/23/18, 09:25
-
Andreas Wolf commented on patch set 6 06/23/18, 09:25
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit eaa1644c893aca6b06dc687a9c2f4ca029f7db57