Review main Merged

54348[BUGFIX] Support fragment/section for record links

Mathias Brodala CR +2 V +2 Easy +8 −0 updated 06/23/18, 09:25

Commit message

This allows for setting fragments e.g. by adding a custom recordlist
RecordLinkHandler.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Alexander Stehlik +1
    • Frank Nägler +1
    • Stefan Neufeind +1
    • Jörg Bösche +1
    • Sebastian Hofer +1
  • Verified V +2
    • Andreas Wolf +2
    • Alexander Stehlik +1
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2833

Show 58 earlier messages
  1. Mathias Brodala uploaded patch set 1 10/10/17, 10:58

  2. TYPO3com voted on patch set 1 V +1 10/10/17, 11:08 Completed build in 09m 31s on Tue, 10 Oct, 01:08 PM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15517

  3. Andreas Kienast voted on patch set 1 CR +1 10/10/17, 11:10

  4. Mathias Brodala uploaded patch set 2 10/10/17, 12:04

  5. Mathias Brodala updated the commit message in patch set 3 10/10/17, 12:06

  6. TYPO3com voted on patch set 2 V +1 10/10/17, 12:16 Completed build in 11m 31s on Tue, 10 Oct, 02:16 PM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15522

  7. TYPO3com voted on patch set 3 V +1 10/10/17, 12:18 Completed build in 12m 20s on Tue, 10 Oct, 02:18 PM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15523

  8. Jörg Bösche updated the commit message in patch set 4 10/14/17, 21:22

  1. Jörg Bösche voted on patch set 4 CR +1 10/14/17, 21:23

  2. TYPO3com voted on patch set 4 V +1 10/14/17, 21:31 Completed build in 08m 46s on Sat, 14 Oct, 11:31 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15650

  3. Sonja Großewinkelmann voted on patch set 4 CR +1 10/16/17, 07:18

  4. Susi Moog commented on patch set 4 10/16/17, 17:39

    how can we test this?
  5. Georg Ringer commented on patch set 4 10/16/17, 17:59

    RecordLinkHandler.php:46

    is there a reason why not just using '#' . $parameters['fragment'];?
  6. Mathias Brodala commented on patch set 4 10/17/17, 10:19

    RecordLinkHandler.php:46 Reply

    I just followed the code style established above.
  7. Mathias Brodala commented on patch set 4 10/17/17, 10:23

    > how can we test this? You'll need a custom recordlist linkhandler registered in TCEMAIN.linkHandler which adds a "lparams" field similar to this: https://github.com/TYPO3/TYPO3.CMS/blob/ae18caad69fee5920adeb82d13ba98ba58cadf24/typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php#L546-L556
  8. Mathias Brodala commented on patch set 4 CR -1 10/17/17, 10:24

    I'll need to have another look to ensure this also works properly for link fields, not only RTE links.
  9. Mathias Schreiber commented on patch set 4 03/01/18, 21:01

    What's the result of the 4month thinking period? :)
  10. Anja Leichsenring commented on patch set 4 04/14/18, 14:35

    ping? anything doing?
  11. Mathias Brodala commented on patch set 4 06/06/18, 13:32

    I'll at least rebase.
  12. Mathias Brodala uploaded patch set 5 06/06/18, 13:40

  13. TYPO3com voted on patch set 5 V +1 06/06/18, 13:49 Completed build in 08m 58s on Wed, 6 Jun, 03:49 PM Test Summary: 31143 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24088

  14. Frank Nägler commented on patch set 5 06/08/18, 12:36

    RecordLinkHandler.php:46

    a simple string concatenation would also work here ;)
  15. Mathias Brodala commented on patch set 5 06/08/18, 13:19

    RecordLinkHandler.php:46 Reply

    Sure, but please see my answer to exactly this remark on October 17th last year. ;-)
  16. Frank Nägler commented on patch set 5 06/08/18, 13:23

    RecordLinkHandler.php:46 Reply

    ok, no problem :D
  17. Frank Nägler voted on patch set 5 CR +1 06/08/18, 14:45

  18. Jörg Bösche voted on patch set 5 CR +1 06/11/18, 16:00

  19. Stefan Neufeind commented on patch set 5 V +1 CR +1 06/11/18, 17:32

    Works for me with a hand-added fragment in a record-link. Without the patch "parameters:fragment" for a typolink is empty. Should the RecordLinkHandler also have an input for a fragment? But that can come as a separate change (maybe for master only), if we desire so.
  20. Mathias Brodala commented on patch set 5 06/12/18, 07:16

    > Works for me with a hand-added fragment in a record-link. Without > the patch "parameters:fragment" for a typolink is empty. Heh, I didn't think of this very easy test, thanks. ;-) > Should the RecordLinkHandler also have an input for a fragment? But > that can come as a separate change (maybe for master only), if we > desire so. I agree.
  21. Sebastian Hofer voted on patch set 5 CR +1 06/22/18, 22:20

  22. Alexander Stehlik commented on patch set 5 V +1 CR +1 06/22/18, 23:36

    Works like expected. A hint: when the fragment is numeric TypoLink will prefix it with a "c".
  23. Andreas Wolf voted on patch set 5 V +2 CR +2 06/23/18, 09:25

  24. Andreas Wolf merged patch set 6 06/23/18, 09:25

  25. Andreas Wolf commented on patch set 6 06/23/18, 09:25

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit eaa1644c893aca6b06dc687a9c2f4ca029f7db57