54349[PATCH] [!!!][TASK] Merge EXT:filemetadata into EXT:core
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 16
- typo3/sysext/core/Configuration/TCA/sys_file_metadata.php+497 −12
- typo3/sysext/core/Configuration/TsConfig/Page/SimplifySysFileMetadata.txtnew+27 −0
- typo3/sysext/core/Documentation/Changelog/master/Breaking-82718-MergedEXTsys_file_metadataIntoEXTcore.rstnew+40 −0
- typo3/sysext/core/Resources/Private/Language/locallang_tca.xlfrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Tca/FileMetadataVisibleFieldsTest.php+130 −9
- typo3/sysext/core/composer.json+3 −1
- typo3/sysext/core/ext_localconf.php+18 −0
- typo3/sysext/core/ext_tables.sql3+25 −0
- typo3/sysext/filemetadata/Configuration/TCA/Overrides/sys_file_metadata.phpdeleted+0 −540
- typo3/sysext/filemetadata/Resources/Public/Icons/Extension.pngdeletedbinary
- typo3/sysext/filemetadata/Tests/Functional/Tca/FileMetadataVisibleFieldsTest.phpdeleted+0 −169
- typo3/sysext/filemetadata/composer.jsondeleted+0 −35
- typo3/sysext/filemetadata/ext_emconf.phpdeleted+0 −20
- typo3/sysext/filemetadata/ext_localconf.phpdeleted+0 −21
- typo3/sysext/filemetadata/ext_tables.sqldeleted+0 −44
- typo3/sysext/filemetadata/LICENSE.txtdeleted+0 −345
Review log 1429
Show 24 earlier messages
-
Georg Ringer uploaded patch set 1 10/10/17, 11:08
-
TYPO3com voted on patch set 1 V -1 10/10/17, 11:08 Completed build in 07s on Tue, 10 Oct, 01:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15518
-
Georg Ringer uploaded patch set 2 10/10/17, 11:12
-
TYPO3com voted on patch set 2 V -1 10/10/17, 11:14 Completed build in 01m 56s on Tue, 10 Oct, 01:14 PM Test Summary: 2443 of 56889 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15519
-
Andreas Kienast commented on patch set 3 10/10/17, 11:19
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V -1 10/10/17, 11:27 Completed build in 08m 17s on Tue, 10 Oct, 01:27 PM Test Summary: 6 of 56961 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15520
-
Björn Jacob updated the commit message in patch set 4 10/10/17, 11:46
-
TYPO3com voted on patch set 4 V -1 10/10/17, 11:56 Completed build in 09m 37s on Tue, 10 Oct, 01:56 PM Test Summary: 15 of 56961 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15521
-
Georg Ringer rebased onto patch set 5 10/10/17, 12:36
-
TYPO3com voted on patch set 5 V -1 10/10/17, 12:47 Completed build in 11m 02s on Tue, 10 Oct, 02:47 PM Test Summary: 4 of 56961 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15527
-
Georg Ringer rebased onto patch set 6 10/10/17, 17:48
-
TYPO3com voted on patch set 6 V -1 10/10/17, 17:58 Completed build in 09m 59s on Tue, 10 Oct, 07:58 PM Test Summary: 4 of 56961 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15531
-
Georg Ringer uploaded patch set 7 10/11/17, 09:09
-
TYPO3com voted on patch set 7 V -1 10/11/17, 09:18 Completed build in 08m 50s on Wed, 11 Oct, 11:18 AM Test Summary: 2 of 56961 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15553
-
Georg Ringer uploaded patch set 8 10/11/17, 18:18
-
TYPO3com voted on patch set 8 V +1 10/11/17, 18:26 Completed build in 08m 25s on Wed, 11 Oct, 08:26 PM Test Summary: 56602 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15560
-
Markus Klein commented on patch set 8 10/11/17, 22:37
ext_tables.sql:356reading this list here I have only one thought: do I really need so many fields most of the time? Or is it just pure waste of disk space? We store this information for each and every file and processed file. That can quickly be a few 100000 records. -
Stefan Neufeind commented on patch set 8 12/09/17, 06:09
ext_tables.sql:356Replyfield is called "fe_group" without s in pages and sys_collection, where it is only a varchar(100) which imho should be sufficient here as well. Should we unify that in the same patch? Maybe as a separate patch but to be merged soon after? While I like to have the plural-name I'm unsure whether it would be better to go with "fe_group" as we have in the other places. -
Stefan Neufeind uploaded patch set 9 12/09/17, 06:21
-
TYPO3com voted on patch set 9 V -1 12/09/17, 06:30 Completed build in 09m 00s on Sat, 9 Dec, 07:30 AM Test Summary: 3 of 57394 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17450
-
TYPO3com commented on patch set 9 12/09/17, 06:32 Completed build in 20m 15s on Sat, 9 Dec, 07:32 AM Test Summary: 3 of 57394 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17450
-
TYPO3com commented on patch set 9 12/09/17, 06:35 Completed build in 33m 54s on Sat, 9 Dec, 07:35 AM Test Summary: 1 of 57394 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17450
-
TYPO3com commented on patch set 9 12/09/17, 06:36 Completed build in 48m 49s on Sat, 9 Dec, 07:36 AM Test Summary: 1 of 57394 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17450
-
TYPO3com commented on patch set 9 12/09/17, 06:38 Completed build in 1h 05m 18s on Sat, 9 Dec, 07:38 AM Test Summary: 1 of 57394 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17450
-
Stefan Neufeind commented on patch set 9 12/09/17, 06:41
bamboo-error imho unrelated to this patchset?ext_tables.sql:361see comments from patchset 8: field is varchar(100) in two other core-tables. Shall we lower it in the same patchset, separate or not at all? Also it is called "fe_group" (Singular) in the other tables - not sure how to go about "unifying" that naming. -
TYPO3com commented on patch set 9 12/11/17, 03:54 Completed build in 22h 38m 05s on Mon, 11 Dec, 04:54 AM Test Summary: 1 of 57394 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17450
-
TYPO3com commented on patch set 9 12/11/17, 07:35 Completed build in 23h 51m 29s on Mon, 11 Dec, 08:35 AM Test Summary: 1 of 57394 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17450
-
Stefan Neufeind commented on patch set 9 12/11/17, 10:14
@Markus: Benni suggested to bring up the question on http://decisions.typo3.org/ whether to add "all those fields". Imho while some few might possibly make sense in the core not all do. But keeping that small extension separate is imho also not ideal. -
Georg Ringer abandoned the change 12/11/17, 19:39
I abandon that, the better solution would be to move that ext to friendsoftypo3/filemetadata