Review main Merged

54364[TASK] SchedulerModuleController: Don't extend BaseScriptClass

Christian Kuhn CR +2 V +2 Normal +106 −117 updated 10/12/17, 10:29

Commit message

To further phase out BaseScriptTask "SOBE", the scheduler
controller class no longer extends it and copies left over
usages to itself.

A general cleanup is applied along with this patch:
* Hard code some general variables like "moduleName"
* Remove some duplicate class attributes
* Additional namespace usages

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Frank Nägler +1
  • Verified V +2
    • Benni Mack +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Christian Kuhn uploaded patch set 1 10/10/17, 20:20

  2. Christian Kuhn updated the commit message in patch set 2 10/10/17, 20:21

  3. TYPO3com voted on patch set 1 V -1 10/10/17, 20:30 Completed build in 10m 12s on Tue, 10 Oct, 10:30 PM Test Summary: 1 of 56963 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15536

  4. TYPO3com voted on patch set 2 V -1 10/10/17, 20:31 Completed build in 10m 03s on Tue, 10 Oct, 10:31 PM Test Summary: 1 of 56963 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15537

  5. Christian Kuhn uploaded patch set 3 10/10/17, 20:47

  6. TYPO3com voted on patch set 3 V +1 10/10/17, 20:57 Completed build in 09m 56s on Tue, 10 Oct, 10:57 PM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15539

  7. Benni Mack commented on patch set 3 CR +1 10/11/17, 18:26

    SchedulerModuleController.php:1503

    this one is great. LOL
  8. Wouter Wolters voted on patch set 3 CR +1 10/12/17, 08:49

  9. Frank Nägler voted on patch set 3 CR +1 V +1 10/12/17, 09:50

  10. Benni Mack voted on patch set 3 CR +2 V +2 10/12/17, 10:29

  11. Gerrit merged patch set 3 10/12/17, 10:29