Review main Merged

54372[BUGFIX] Use strict flag in signalslot dispatcher

Georg Ringer CR +2 V +2 Easy +3 −1 updated 12/21/17, 13:32

Commit message

To avoid exceptions with complex structures, the strict flag
must be used in the in_array check.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 10/12/17, 07:04

  2. Andreas Kienast voted on patch set 1 CR +1 10/12/17, 07:14

  3. TYPO3com voted on patch set 1 V +1 10/12/17, 07:14 Completed build in 09m 53s on Thu, 12 Oct, 09:14 AM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15571

  4. Markus Klein commented on patch set 2 10/12/17, 08:08

    Published edit on patch set 1.
  5. Markus Klein voted on patch set 2 CR +2 V +2 10/12/17, 08:08

  6. TYPO3com voted on patch set 2 V +1 10/12/17, 08:20 Completed build in 11m 23s on Thu, 12 Oct, 10:20 AM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15572

  7. Andreas Kienast voted on patch set 2 CR +1 10/12/17, 08:39

  8. Wouter Wolters voted on patch set 2 CR +1 10/12/17, 08:48

  9. Frank Nägler voted on patch set 2 CR +1 V +1 10/12/17, 13:04

  10. Gerrit merged patch set 2 10/12/17, 13:26

  11. Stephan Großberndt commented on patch set 3 12/20/17, 16:48

    Backport to 8.7 and 7.6 is missing
  12. Markus Klein commented on patch set 3 12/21/17, 13:32

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ea70f8d67439ba87f26ab9e2706753a4ea50d922