Review main Merged

54375[TASK] Rename ext:lowlevel/View to ext:lowlevel/Controller

Christian Kuhn CR +2 V +2 Normal +66 −8 updated 10/12/17, 12:19

Commit message

The two "view" classes are clearly controllers and are
renamed with this patch accordingly.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 67

  1. Christian Kuhn uploaded patch set 1 10/12/17, 11:12

  2. Mathias Brodala commented on patch set 1 10/12/17, 11:20

    ClassAliasMap.php:3

    Just asking since I always wondered: why not use \TYPO3\CMS\Lowlevel\View\ConfigurationView::class here? PHP resolves this to its string value, no matter if the class exists.
  3. TYPO3com voted on patch set 1 V +1 10/12/17, 11:22 Completed build in 09m 14s on Thu, 12 Oct, 01:22 PM Test Summary: 56604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15582

  4. Christian Kuhn commented on patch set 1 10/12/17, 11:24

    ClassAliasMap.php:3 Reply

    no warning in phpstorm ;)
  5. Frank Nägler voted on patch set 1 CR +1 V +1 10/12/17, 11:38

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 10/12/17, 12:19

  7. Gerrit merged patch set 1 10/12/17, 12:19