54381[!!!][TASK] Replace ClassInfo with ClassSchema
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 2
Files 52
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −9
- typo3/sysext/core/Documentation/Changelog/master/Breaking-57594-OptimizeReflectionServiceCacheHandling.rstnew+63 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-57594-OptimizeReflectionServiceCacheHandling.rstnew+42 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-57594-OptimizeReflectionServiceCacheHandling.rstnew+54 −0
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+0 −45
- typo3/sysext/extbase/Classes/Mvc/Cli/Command.php+29 −29
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php+0 −13
- typo3/sysext/extbase/Classes/Mvc/RequestHandlerResolver.php+0 −13
- typo3/sysext/extbase/Classes/Object/Container/ClassInfo.phpdeleted+0 −170
- typo3/sysext/extbase/Classes/Object/Container/ClassInfoCache.phpdeleted+0 −84
- typo3/sysext/extbase/Classes/Object/Container/ClassInfoFactory.phpdeleted+0 −172
- typo3/sysext/extbase/Classes/Object/Container/Container.php+45 −91
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Session.php+0 −13
- typo3/sysext/extbase/Classes/Reflection/ClassReflection.phpdeleted+0 −187
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php1+437 −4
- typo3/sysext/extbase/Classes/Reflection/MethodReflection.phpdeleted+0 −111
- typo3/sysext/extbase/Classes/Reflection/ObjectAccess.php+8 −4
Show 32 more files
- typo3/sysext/extbase/Classes/Reflection/ParameterReflection.phpdeleted+0 −46
- typo3/sysext/extbase/Classes/Reflection/PropertyReflection.phpdeleted+0 −98
- typo3/sysext/extbase/Classes/Reflection/ReflectionService.php7+64 −418
- typo3/sysext/extbase/Classes/Scheduler/TaskExecutor.php+0 −9
- typo3/sysext/extbase/Tests/Unit/Mvc/Cli/Fixture/Command/MockCCommandController.phpnew+60 −0
- typo3/sysext/extbase/Tests/Unit/Mvc/Cli/CommandTest.php+168 −56
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+6 −3
- typo3/sysext/extbase/Tests/Unit/Object/Container/ClassInfoFactoryTest.phpdeleted+0 −81
- typo3/sysext/extbase/Tests/Unit/Object/Container/ContainerTest.php+3 −35
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+30 −12
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/Fixtures/Query.phpnew+22 −0
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/PersistentObjectConverterTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfMethods.phpnew+75 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfProperties.phpnew+56 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithConstructorAndConstructorArguments.phpnew+27 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithConstructorAndConstructorArgumentsWithDependencies.phpnew+27 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyModel.phpnew+24 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyModelRepository.phpnew+24 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+166 −37
- typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php+25 −9
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+1 −2
- typo3/sysext/install/Classes/Configuration/ExtbaseObjectCache/ApcPreset.phpdeleted+0 −67
- typo3/sysext/install/Classes/Configuration/ExtbaseObjectCache/ApcuPreset.phpdeleted+0 −67
- typo3/sysext/install/Classes/Configuration/ExtbaseObjectCache/DatabasePreset.phpdeleted+0 −57
- typo3/sysext/install/Classes/Configuration/ExtbaseObjectCache/ExtbaseObjectCacheFeature.phpdeleted+0 −37
- typo3/sysext/install/Classes/Configuration/FeatureManager.php+0 −2
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+33 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+70 −0
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/ExtbaseObjectCache/Apc.htmldeleted+0 −37
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/ExtbaseObjectCache/Apcu.htmldeleted+0 −37
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/ExtbaseObjectCache/Database.htmldeleted+0 −28
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/ExtbaseObjectCache.htmldeleted+0 −27
Review log 4064
Show 2139 earlier messages
-
Alexander Schnitzler uploaded patch set 1 10/12/17, 15:00
-
TYPO3com voted on patch set 1 V -1 10/12/17, 15:00 Completed build in 10s on Thu, 12 Oct, 05:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15590
-
Alexander Schnitzler uploaded patch set 2 10/12/17, 15:01
-
TYPO3com voted on patch set 2 V -1 10/12/17, 15:11 Completed build in 09m 57s on Thu, 12 Oct, 05:11 PM Test Summary: 362 of 57029 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15591
-
Alexander Schnitzler uploaded patch set 3 10/12/17, 15:59
-
TYPO3com voted on patch set 3 V -1 10/12/17, 16:08 Completed build in 09m 06s on Thu, 12 Oct, 06:08 PM Test Summary: 380 of 57035 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15592
-
Oliver Klee updated the commit message in patch set 4 10/12/17, 16:18
-
TYPO3com voted on patch set 4 V -1 10/12/17, 16:28 Completed build in 09m 27s on Thu, 12 Oct, 06:28 PM Test Summary: 380 of 57035 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15593
-
Alexander Schnitzler uploaded patch set 5 10/12/17, 20:27
-
Alexander Schnitzler updated the commit message in patch set 6 10/12/17, 20:28
-
Alexander Schnitzler uploaded patch set 7 10/12/17, 20:37
-
TYPO3com voted on patch set 5 V -1 10/12/17, 20:37 Completed build in 10m 39s on Thu, 12 Oct, 10:37 PM Test Summary: 371 of 57059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15599
-
TYPO3com voted on patch set 6 V -1 10/12/17, 20:39 Completed build in 10m 30s on Thu, 12 Oct, 10:39 PM Test Summary: 370 of 57059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15600
-
TYPO3com voted on patch set 7 V -1 10/12/17, 20:46 Completed build in 09m 15s on Thu, 12 Oct, 10:46 PM Test Summary: 370 of 57059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15601
-
Alexander Schnitzler uploaded patch set 8 10/13/17, 08:23
-
TYPO3com voted on patch set 8 V -1 10/13/17, 08:32 Completed build in 09m 25s on Fri, 13 Oct, 10:32 AM Test Summary: 362 of 57059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15607
-
Alexander Schnitzler uploaded patch set 9 10/13/17, 09:32
-
TYPO3com voted on patch set 9 V -1 10/13/17, 09:41 Completed build in 08m 37s on Fri, 13 Oct, 11:41 AM Test Summary: 23 of 57059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15613
-
Alexander Schnitzler uploaded patch set 10 10/13/17, 10:23
-
TYPO3com voted on patch set 10 V -1 10/13/17, 10:32 Completed build in 08m 43s on Fri, 13 Oct, 12:32 PM Test Summary: 15 of 57059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15615
-
Alexander Schnitzler uploaded patch set 11 10/13/17, 11:37
-
TYPO3com voted on patch set 11 V -1 10/13/17, 11:46 Completed build in 09m 36s on Fri, 13 Oct, 01:46 PM Test Summary: 11 of 57059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15617
-
Alexander Schnitzler uploaded patch set 12 10/13/17, 12:18
-
TYPO3com voted on patch set 12 V -1 10/13/17, 12:27 Completed build in 09m 22s on Fri, 13 Oct, 02:27 PM Test Summary: 134 of 57059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15618
-
Alexander Schnitzler uploaded patch set 13 10/13/17, 13:15
-
TYPO3com voted on patch set 13 V -1 10/13/17, 13:24 Completed build in 08m 40s on Fri, 13 Oct, 03:24 PM Test Summary: 11 of 57059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15620
-
TYPO3com commented on patch set 13 10/13/17, 13:27 Completed build in 20m 35s on Fri, 13 Oct, 03:27 PM Test Summary: 11 of 57059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15620
-
Alexander Schnitzler uploaded patch set 14 10/13/17, 13:57
-
TYPO3com voted on patch set 14 V +1 10/13/17, 14:07 Completed build in 09m 35s on Fri, 13 Oct, 04:07 PM Test Summary: 56700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15621
-
Benni Mack uploaded patch set 15 10/16/17, 10:32
-
TYPO3com voted on patch set 15 V +1 10/16/17, 10:41 Completed build in 09m 16s on Mon, 16 Oct, 12:41 PM Test Summary: 56708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15665
-
Susi Moog commented on patch set 15 10/17/17, 09:38
ReflectionService.php:56cachingEnabled would be sufficient.ReflectionService.php:71please add a comment here what that part is doing or use a named private method, it's not so clear what the substr is supposed to achieve. -
Susi Moog commented on patch set 15 10/17/17, 09:55
ReflectionService.php:71Replyat a guess: it's removing the php tag - maybe we should have a cache that does not write that tag as we remove it in more than one place. -
Susi Moog commented on patch set 15 10/17/17, 10:17
ReflectionService.php:71Reply>> why is extbase_reflection cache a PhpFrontend? Wouldn't a VariableFrontend make more sense? -
Susi Moog uploaded patch set 16 10/17/17, 12:16
-
TYPO3com voted on patch set 16 V -1 10/17/17, 12:26 Completed build in 09m 43s on Tue, 17 Oct, 02:26 PM Test Summary: 12 of 57055 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15717
-
Wouter Wolters commented on patch set 16 10/17/17, 12:42
approaches -
Susi Moog uploaded patch set 17 10/17/17, 13:10
-
TYPO3com voted on patch set 17 V -1 10/17/17, 13:10 Completed build in 11s on Tue, 17 Oct, 03:10 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15719
-
Susi Moog uploaded patch set 18 10/17/17, 13:15
-
TYPO3com voted on patch set 18 V +1 10/17/17, 13:24 Completed build in 08m 47s on Tue, 17 Oct, 03:24 PM Test Summary: 56696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15720
-
Benni Mack commented on patch set 19 10/17/17, 14:04
Published edit on patch set 18. -
TYPO3com voted on patch set 19 V +1 10/17/17, 14:13 Completed build in 09m 07s on Tue, 17 Oct, 04:13 PM Test Summary: 56696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15721
-
Benni Mack uploaded patch set 20 10/17/17, 14:39
-
TYPO3com voted on patch set 20 V -1 10/17/17, 14:48 Completed build in 08m 52s on Tue, 17 Oct, 04:48 PM Test Summary: 694 of 57055 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15722
-
Benni Mack uploaded patch set 21 10/17/17, 14:50
-
TYPO3com voted on patch set 21 V +1 10/17/17, 15:01 Completed build in 10m 24s on Tue, 17 Oct, 05:01 PM Test Summary: 56696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15724
-
Benni Mack voted on patch set 21 CR +1 V +1 10/17/17, 15:08
-
Susi Moog voted on patch set 21 CR +2 V +2 10/17/17, 15:08
-
Susi Moog voted on patch set 21 CR -1 V 0 10/17/17, 15:09
-
Benni Mack uploaded patch set 22 10/17/17, 15:12
-
Benni Mack voted on patch set 22 CR +1 V +1 10/17/17, 15:17
-
TYPO3com voted on patch set 22 V -1 10/17/17, 15:21 Completed build in 08m 12s on Tue, 17 Oct, 05:21 PM Test Summary: 1 of 57055 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15726
-
TYPO3com voted on patch set 22 V +1 10/17/17, 15:22 Completed build in 18m 14s on Tue, 17 Oct, 05:22 PM Test Summary: 56696 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15726
-
Susi Moog voted on patch set 22 CR +2 V +2 10/17/17, 15:35
-
Gerrit merged patch set 22 10/17/17, 15:35
-
Tymoteusz Motylewski commented on patch set 23 10/17/17, 15:39
just to make sure - will the removal of cache per plugin break usages when you have different TS configuration per plugin (e.g. config for overriding classes) ? -
Susi Moog commented on patch set 23 10/17/17, 15:52
Object overwriting uses registerImplementation internally and resolves the different class name before calling the ReflectionService - therefore no change in that behavior. The ReflectionService does not have any information about class name mappings or the like. -
Tymoteusz Motylewski commented on patch set 23 10/17/17, 17:25
awesome, thanks! -
Marc Bastian Heinrichs commented on patch set 23 10/18/17, 08:07
yeah, cool! thx for fixing this long waiting issues. Just had only time for a short overview for now, so no voting from my side for the moment. -
Marc Bastian Heinrichs commented on patch set 23 10/18/17, 08:08
which is too late anyway :-) -
Helmut Hummel commented on patch set 23 10/20/17, 12:37
ReflectionService.php:79as far as I understand the PHP documentation, destructing objects may occur in any order, which means, than the dataCache instance might be gone at this point already. I think we should keep the shutdown method and maybe call it in TYPO3 bootstrap shutdown to be sure cache is written -
Benni Mack commented on patch set 23 10/20/17, 15:07
ReflectionService.php:79Replygood catch. However, we can't be quite sure that the bootstrap->shutdown() method is called at all times. mostly because you have "extbase->redirect()" etc logic which does not call bootstrap shutdown. we could add a shutdown() method, called in bootstrap, and also call shutdown in this __destruct() method, checking if the data cache object is still there, then persist here. -
Markus Klein commented on patch set 23 07/06/20, 07:58
ReflectionService.php:498UnresolvedThis handling for transient properties has been silently removed. I suppose this was done by accident. See also https://forge.typo3.org/issues/91726
ClassSchema.php:555