54395[TASK] Add Fluid expressions and pre-processors global config
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Mattias Nilsson +1
- Jan Stockfisch +1
- Jörg Bösche +1
-
Verified V +2
- Jigal van Hemert +2
- Mattias Nilsson +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1316
-
Claus Due uploaded patch set 1 10/14/17, 12:20
-
TYPO3com voted on patch set 1 V -1 10/14/17, 12:20 Completed build in 08s on Sat, 14 Oct, 02:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15626
-
Claus Due uploaded patch set 2 10/14/17, 12:25
-
TYPO3com voted on patch set 2 V +1 10/14/17, 12:35 Completed build in 09m 20s on Sat, 14 Oct, 02:35 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15627
-
Mattias Nilsson voted on patch set 2 CR +1 V +1 10/17/17, 18:25
-
Jörg Bösche commented on patch set 3 10/19/17, 08:01
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 10/19/17, 08:10 Completed build in 09m 03s on Thu, 19 Oct, 10:10 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15790
-
Mattias Nilsson voted on patch set 3 CR +1 V +1 10/19/17, 08:17
-
Andreas Kienast commented on patch set 3 10/19/17, 08:23
I'm undecided whether this already qualifies as a feature, which means, no backport to 8.7 then. -
Claus Due commented on patch set 3 11/05/17, 19:16
Pingaling. Time is *quickly* running out on this one if we want that in v9 at first release. -
Benni Mack commented on patch set 3 11/05/17, 20:22
RenderingContext.php:74one question: why move them out of the else-clause into the main part, overriding internal framework instantiation from above? (just for the sake of understanding the impact) -
Claus Due commented on patch set 3 11/05/17, 21:33
RenderingContext.php:74ReplyThis has a couple of different perspectives attached to it, but most importantly: 1) It will soon no longer be necessary to pass the view instance, which in turn makes this condition redundant, and the code would need to be moved anyway. 2) By moving it outside now, we also apply this configuration to usages which do pass the view currently, so they get the configured processors/expressions as well. At the time of writing this, the only case that exists in TYPO3 CMS is in EXT:core in the ErrorPageController - although that's a VERY edge case it still means that our new option gets applied to that use case as well. See https://github.com/TYPO3/Fluid/pull/340 I think in light of 1) and 2) combined the conclusion should be that it's safe to put this here now even though the $view dependency is still not completely removed. If we do go and merge the linked patch it will still be safe - and we can even follow it up with a patch that removes $view from our RenderingContext as well without breaking anything, which would really make it obvious since there's just one init flow. -
Jörg Bösche voted on patch set 3 CR +1 11/06/17, 08:34
-
Jan Stockfisch voted on patch set 3 CR +1 11/06/17, 09:34
-
Jigal van Hemert voted on patch set 3 CR +2 V +2 11/07/17, 12:55
-
Gerrit merged patch set 3 11/07/17, 12:55