Review main Merged

54413[TASK] Move BackendController addInlineSettings calls to _construct

Tymoteusz Motylewski CR +2 V +2 Easy +5 −5 updated 10/17/17, 09:10

Commit message

Move calls to addInlineSettings out of the foreach loop, and place them
together with other similar calls.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 68

  1. Tymoteusz Motylewski uploaded patch set 1 10/17/17, 08:59

  2. Tymoteusz Motylewski updated the commit message in patch set 2 10/17/17, 09:00

  3. Wouter Wolters voted on patch set 2 CR +1 10/17/17, 09:01

  4. Wouter Wolters voted on patch set 2 V +1 10/17/17, 09:02

  5. Georg Ringer voted on patch set 2 CR +2 V +2 10/17/17, 09:05

  6. Gerrit merged patch set 2 10/17/17, 09:05

  7. TYPO3com commented on patch set 1 10/17/17, 09:08 Completed build in 09m 16s on Tue, 17 Oct, 11:08 AM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15710

  8. TYPO3com commented on patch set 2 10/17/17, 09:10 Completed build in 10m 05s on Tue, 17 Oct, 11:10 AM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15711