Review main Merged

54416[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths

Benjamin Franzke CR +2 V +2 Normal +66 −6 updated 12/20/17, 16:42

Commit message

FLUIDTEMPLATE variables may contain content elements (e.g. recursive
FLUIDTEMPLATE's) which may instantiate own TemplateViews
(e.g. StandaloneView).
A recursive StandaloneView will statically(!!) cache used TemplatesPaths
in \TYPO3Fluid\Fluid\View\Templates::resolvedFiles.

If StandaloneView is instantiated before, but the fluid layout path is
calculated after inner content objects are being rendering,
the altered statically cached `resolvedFiles` cache is used
and contains invalid layoutRootPaths.

Short term solution:
Defer the initialization of the StandaloneView (which flushes those
buggy caches) until all variables have been processed.

Review

  • Code review CR +2
    • Susi Moog +2
    • Sebastian Hofer +1
  • Verified V +2
    • Susi Moog +2
    • Sebastian Hofer +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1522

  1. Benjamin Franzke uploaded patch set 1 10/17/17, 14:53

  2. TYPO3com voted on patch set 1 V +1 10/17/17, 15:03 Completed build in 09m 57s on Tue, 17 Oct, 05:03 PM Test Summary: 56612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15725

  3. Helmut Hummel commented on patch set 1 10/18/17, 10:19

    I think we should add functional test cases for this one. should be fairly easy with the fluid_test extension which meanwhile is part of our test suite
  4. Benjamin Franzke uploaded patch set 2 10/18/17, 13:55

  5. TYPO3com voted on patch set 2 V -1 10/18/17, 13:55 Completed build in 08s on Wed, 18 Oct, 03:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15763

  6. Benjamin Franzke uploaded patch set 3 10/18/17, 13:58

  7. TYPO3com voted on patch set 3 V -1 10/18/17, 13:58 Completed build in 08s on Wed, 18 Oct, 03:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15764

  8. Benjamin Franzke uploaded patch set 4 10/18/17, 14:07

  9. TYPO3com voted on patch set 4 V -1 10/18/17, 14:17 Completed build in 10m 01s on Wed, 18 Oct, 04:17 PM Test Summary: 1 of 57117 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15766

  10. Benjamin Franzke uploaded patch set 5 10/18/17, 14:30

  11. TYPO3com voted on patch set 5 V +1 10/18/17, 14:39 Completed build in 08m 30s on Wed, 18 Oct, 04:39 PM Test Summary: 56758 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15767

  12. Benjamin Franzke updated the commit message in patch set 6 10/19/17, 08:29

  13. TYPO3com voted on patch set 6 V -1 10/19/17, 08:37 Completed build in 08m 47s on Thu, 19 Oct, 10:37 AM Test Summary: 2 of 57117 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15792

  14. TYPO3com voted on patch set 6 V +1 10/19/17, 09:04 Completed build in 43m 57s on Thu, 19 Oct, 11:04 AM Test Summary: 56758 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15792

  15. Benni Mack commented on patch set 6 10/20/17, 23:34

    From what I get so far: Why do we actually hand over the TemplatePaths object recursively at all? Where does that happen?
  16. Benjamin Franzke commented on patch set 6 10/21/17, 12:15

    > From what I get so far: Why do we actually hand over the > TemplatePaths object recursively at all? Where does that happen? I probably should've called it "nested" FLUIDTEMPLATE cObjs, not recursive. It happends implicitly through typoscript configuration that uses a FLUIDTEMPLATE cObj as a variable for another (the outer) FLUIDTEMPLATE cObj.
  17. Susi Moog voted on patch set 6 CR +1 V +1 11/27/17, 11:26

  18. Sebastian Hofer voted on patch set 6 CR +1 11/28/17, 15:14

  19. Sebastian Hofer voted on patch set 6 V +1 11/29/17, 16:35

  20. Susi Moog voted on patch set 6 CR +2 V +2 11/29/17, 17:12

  21. Gerrit merged patch set 6 11/29/17, 17:13

  22. Stephan Großberndt commented on patch set 7 12/20/17, 16:42

    Backport to 8.7 is missing