Review TYPO3_7-6 Merged

54417[BUGFIX] Fix declaration of injectView in install tool

Susi Moog CR +2 V +2 Easy +12 −1 updated 10/17/17, 23:37

Commit message

When using PHP7 declarations of sub classes have to
be compatible to their parent declarations.

As the install tool has been completely refactored in
newer TYPO3 version this patch implements only a
workaround to prevent the PHP warning.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Oliver Hader +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 913

  1. Susi Moog uploaded patch set 1 10/17/17, 16:24

  2. Susi Moog commented on patch set 2 10/17/17, 16:24

    Published edit on patch set 1.
  3. Susi Moog commented on patch set 3 10/17/17, 16:25

    Published edit on patch set 2.
  4. Christian Kuhn voted on patch set 3 CR +1 10/17/17, 16:28

  5. TYPO3com voted on patch set 1 V +1 10/17/17, 16:30 Completed build in 06m 38s on Tue, 17 Oct, 06:30 PM Test Summary: 39204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1165

  6. TYPO3com voted on patch set 2 V +1 10/17/17, 16:34 Completed build in 09m 39s on Tue, 17 Oct, 06:34 PM Test Summary: 39204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1166

  7. TYPO3com voted on patch set 3 V +1 10/17/17, 16:36 Completed build in 11m 15s on Tue, 17 Oct, 06:36 PM Test Summary: 39204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1167

  8. Benni Mack updated the commit message in patch set 4 10/17/17, 16:47

  9. TYPO3com voted on patch set 4 V +1 10/17/17, 16:52 Completed build in 05m 02s on Tue, 17 Oct, 06:52 PM Test Summary: 39204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1168

  10. Wouter Wolters voted on patch set 4 CR +1 10/17/17, 16:55

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 10/17/17, 20:34

  12. Oliver Hader voted on patch set 4 CR +2 V +2 10/17/17, 23:37

  13. Gerrit merged patch set 4 10/17/17, 23:37