Review main Merged

54422[BUGFIX] Localization State does not properly sanitize and enrich

Oliver Hader CR +2 V +2 Normal +212 −4 updated 10/17/17, 22:47

Commit message

The Localization State object has an incomplete assignment in the
constructor - sanitize processing is overridden by enrich processing,
however both should be combined instead.

The current side-effects were, that
* localization state could contain fields that were not defined in TCA
  having support for the `allowLanguageSynchronization` setting
* state values different than `custom`, `source` or `parent` have not
  been overridden by the default `parent` value

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 710

  1. Oliver Hader uploaded patch set 1 10/17/17, 21:08

  2. Wouter Wolters voted on patch set 1 CR +1 10/17/17, 21:14

  3. TYPO3com voted on patch set 1 V -1 10/17/17, 21:19 Completed build in 11m 06s on Tue, 17 Oct, 11:19 PM Test Summary: 2 of 57115 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15741

  4. TYPO3com voted on patch set 1 V +1 10/17/17, 21:26 Completed build in 29m 04s on Tue, 17 Oct, 11:26 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15741

  5. Susi Moog uploaded patch set 2 10/17/17, 21:54

  6. TYPO3com voted on patch set 2 V +1 10/17/17, 22:06 Completed build in 11m 45s on Wed, 18 Oct, 12:06 AM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15746

  7. Susi Moog voted on patch set 2 CR +1 V +1 10/17/17, 22:07

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 10/17/17, 22:47

  9. Gerrit merged patch set 2 10/17/17, 22:47

  10. Christian Kuhn commented on patch set 3 10/17/17, 22:47

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 73a555295f587c61346744dc2eae6601069c9a04