Review main Merged

54426[BUGFIX] Do not force content_fallback to default page language

Benni Mack CR +2 V +2 Easy +46 −4 updated 10/26/17, 23:21

Commit message

If a page translation is not available, the TypoScript option
`config.sys_language_mode` has the option
`content_fallback;listofuids` to define to which other language
translations should be fallen back.

However, if NONE of the defined page translations are available,
a fallback to the DEFAULT language is made (because the
foreach just does not apply) which can not be stopped at all.

To define an explicit 404 when a translated page NOR its
fallbacks are available the special keyword "pageNotFound" is added,
which can be added to
`config.sys_language_mode = content_fallback;3,2,pageNotFound`
and if none of 3,2 are available, a page not found message
is thrown.

Review

  • Code review CR +2
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2
    • Susi Moog +2
    • Georg Ringer +1
    • Sascha Rademacher +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2027

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 10/17/17, 22:06

  2. TYPO3com voted on patch set 1 V -1 10/17/17, 22:15 Completed build in 09m 20s on Wed, 18 Oct, 12:15 AM Test Summary: 12 of 57055 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15747

  1. Georg Ringer commented on patch set 1 10/18/17, 07:03

    this still must have a feature rst then, doesn't it?
  2. Benni Mack uploaded patch set 2 10/18/17, 19:41

  3. TYPO3com voted on patch set 2 V +1 10/18/17, 19:51 Completed build in 10m 32s on Wed, 18 Oct, 09:51 PM Test Summary: 56756 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15776

  4. Benni Mack commented on patch set 2 10/18/17, 20:40

    As this is a bugfix, I would go with an Important.rst and update TS reference accordingly for v8 as well - fine for you Georg?
  5. Benni Mack voted on patch set 2 CR -1 10/18/17, 23:08

  6. Georg Ringer commented on patch set 2 10/19/17, 08:13

    sure ;)
  7. Benni Mack uploaded patch set 3 10/19/17, 21:56

  8. TYPO3com voted on patch set 3 V +1 10/19/17, 22:05 Completed build in 09m 23s on Fri, 20 Oct, 12:05 AM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15807

  9. Andreas Kienast commented on patch set 3 10/20/17, 06:33

    Important-82794-AddedSysLanguageModeFallbackStop.rst:12

    Am I wrong or isn't it "content_fallback"?
  10. Benni Mack commented on patch set 4 10/20/17, 11:30

    Published edit on patch set 3.
  11. Benni Mack commented on patch set 4 10/20/17, 11:30

    thx
  12. TYPO3com voted on patch set 4 V +1 10/20/17, 11:41 Completed build in 10m 54s on Fri, 20 Oct, 01:41 PM Test Summary: 56762 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15821

  13. Benni Mack commented on patch set 5 10/20/17, 14:16

    Published edit on patch set 4.
  14. TYPO3com voted on patch set 5 V +1 10/20/17, 14:26 Completed build in 09m 53s on Fri, 20 Oct, 04:26 PM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15835

  15. Georg Ringer commented on patch set 5 10/21/17, 16:46

    shouldn't go the rst in master as well?
  16. Benni Mack commented on patch set 6 10/23/17, 06:10

    Published edit on patch set 5.
  17. Benni Mack commented on patch set 6 10/23/17, 06:10

    For master, I'll move it into "master" for, 8.7 branch, it should go into "8.7.x" (which I will take care on the backport)
  18. TYPO3com voted on patch set 6 V -1 10/23/17, 06:19 Completed build in 09m 25s on Mon, 23 Oct, 08:19 AM Test Summary: 1 of 57193 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15842

  19. TYPO3com voted on patch set 6 V +1 10/23/17, 06:47 Completed build in 46m 42s on Mon, 23 Oct, 08:47 AM Test Summary: 56834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-15842

  20. Sascha Rademacher voted on patch set 6 V +1 10/23/17, 07:07

  21. Georg Ringer voted on patch set 6 CR +1 V +1 10/23/17, 07:11

  22. Susi Moog voted on patch set 6 CR +2 V +2 10/23/17, 07:40

  23. Gerrit merged patch set 6 10/23/17, 07:40

  24. Susi Moog commented on patch set 7 10/23/17, 07:40

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit c9aac8ca349327d32d4eba8cf9a360fac66ad20e
  25. Markus Klein commented on patch set 7 10/26/17, 23:21

    Post -1

    Important-82794-AddedSysLanguageModeFallbackStop.rst:4

    besides that this is a feature IMO (and to my knowledge this fallback stuff does not work anyway) this is a wrong heading as the keyword is "pageNotFound"